Re: [PATCH 5/7] dyndbg: WIP replace __dyndbg_callsite section with a zs-pool copy.

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3009 bytes --]

Hi Jim,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on next-20200807]
[cannot apply to linux/master asm-generic/master v5.8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jim-Cromie/dyndbg-WIP-diet-plan/20200808-041343
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 86cfccb66937dd6cbf26ed619958b9e587e6a115
config: i386-randconfig-a003-20200807 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   ld: lib/dynamic_debug.o: in function `ddebug_callsite_put':
   lib/dynamic_debug.c:176: undefined reference to `zs_unmap_object'
   ld: lib/dynamic_debug.o: in function `ddebug_callsite_get':
   lib/dynamic_debug.c:164: undefined reference to `zs_map_object'
   ld: lib/dynamic_debug.o: in function `ddebug_zpool_add':
   lib/dynamic_debug.c:985: undefined reference to `zs_malloc'
   ld: lib/dynamic_debug.c:994: undefined reference to `zs_map_object'
   ld: lib/dynamic_debug.c:1004: undefined reference to `zs_unmap_object'
   ld: lib/dynamic_debug.o: in function `ddebug_callsite_put':
   lib/dynamic_debug.c:176: undefined reference to `zs_unmap_object'
   ld: lib/dynamic_debug.o: in function `ddebug_callsite_get':
   lib/dynamic_debug.c:164: undefined reference to `zs_map_object'
   ld: lib/dynamic_debug.o: in function `ddebug_callsite_put':
   lib/dynamic_debug.c:176: undefined reference to `zs_unmap_object'
   ld: lib/dynamic_debug.o: in function `ddebug_callsite_get':
   lib/dynamic_debug.c:164: undefined reference to `zs_map_object'
   ld: lib/dynamic_debug.o: in function `ddebug_zpool_remove':
>> lib/dynamic_debug.c:1016: undefined reference to `zs_free'
   ld: lib/dynamic_debug.c:1011: undefined reference to `zs_unmap_object'
   ld: lib/dynamic_debug.o: in function `ddebug_zpool_init':
   lib/dynamic_debug.c:1178: undefined reference to `zs_create_pool'
   ld: lib/dynamic_debug.c:1188: undefined reference to `zs_compact'
   ld: lib/dynamic_debug.c:1188: undefined reference to `zs_get_total_pages'

vim +1016 lib/dynamic_debug.c

  1006	
  1007	static void ddebug_zpool_remove(struct _ddebug *dp)
  1008	{
  1009		if (dp->site) {
  1010			pr_warn("zhandle shouldnt be mapped now\n");
  1011			zs_unmap_object(dd_callsite_zpool, dp->zhandle);
  1012		}
  1013		if (!dp->zhandle)
  1014			pr_err("zhandle already cleared !\n");
  1015		else
> 1016			zs_free(dd_callsite_zpool, dp->zhandle);
  1017	}
  1018	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32451 bytes --]