From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89212C433E0 for ; Sat, 8 Aug 2020 18:29:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B0662070A for ; Sat, 8 Aug 2020 18:29:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726415AbgHHS3N (ORCPT ); Sat, 8 Aug 2020 14:29:13 -0400 Received: from foss.arm.com ([217.140.110.172]:37972 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726200AbgHHS3M (ORCPT ); Sat, 8 Aug 2020 14:29:12 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D507C1FB; Sat, 8 Aug 2020 11:29:11 -0700 (PDT) Received: from gaia (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8DB413F7D8; Sat, 8 Aug 2020 11:29:10 -0700 (PDT) Date: Sat, 8 Aug 2020 19:29:08 +0100 From: Catalin Marinas To: Greg Kroah-Hartman Cc: Will Deacon , Gavin Shan , Mark Rutland , Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Sumit Gupta Subject: Re: [PATCH] fix arm64 build with lack of __cpu_logical_map exported Message-ID: <20200808182907.GA2073@gaia> References: <20200808124242.GA352821@kroah.com> <20200808150443.GA492@DESKTOP-O1885NU.localdomain> <20200808152958.GB369184@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200808152958.GB369184@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 08, 2020 at 05:29:58PM +0200, Greg Kroah-Hartman wrote: > On Sat, Aug 08, 2020 at 04:05:00PM +0100, Catalin Marinas wrote: > > On Sat, Aug 08, 2020 at 02:42:42PM +0200, Greg Kroah-Hartman wrote: > > > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > > > index 87e81d29e6fb..b421a4756793 100644 > > > --- a/arch/arm64/kernel/setup.c > > > +++ b/arch/arm64/kernel/setup.c > > > @@ -275,6 +275,7 @@ static int __init reserve_memblock_reserved_regions(void) > > > arch_initcall(reserve_memblock_reserved_regions); > > > > > > u64 __cpu_logical_map[NR_CPUS] = { [0 ... NR_CPUS-1] = INVALID_HWID }; > > > +EXPORT_SYMBOL_GPL(__cpu_logical_map); > > > > This was still under discussion, Sudeep preferring an alternative in the > > driver: > > > > http://lkml.kernel.org/r/20200727172744.GD8003@bogus > > http://lkml.kernel.org/r/20200724131059.GB6521@bogus > > > > Sumit came with a new diff inline that fixes the driver instead of > > exporting the __cpu_logical_map. > > > > https://lore.kernel.org/linux-arm-kernel/e3a4bc21-c334-4d48-90b5-aab8d187939e@nvidia.com/ > > Ok, but having a broken tree is not nice, how did this survive > linux-next testing? I guess defconfig worked ok since tegra194-cpufreq is not a module so we didn't bother much. The fault was reported for allmodconfig but the discussion didn't conclude. > > Sumit, Sudeep, is the above diff sufficient and can it go upstream? > > Note that MIPS already export this symbol, so perhaps the drivers that > need it on that platform should also be fixed the same way? I push Kefeng's patch to the arm64 for-next/core branch which exports cpu_logical_map() as a function. We can revert it later is the Tegra driver is fixed. I'll send Linus a pull request in a bit, once I finish testing the branch. -- Catalin