From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31647C433DF for ; Sat, 8 Aug 2020 23:42:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 022EC20656 for ; Sat, 8 Aug 2020 23:42:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596930166; bh=Ugj656t5RRt2/JcPvMMlruvQsjZtitRhzSD+95JsPLw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1W+9YSmLp6nHwCr2z4kp9P6EaKPXmlC175WR5MMDg/2XwJXyPR+dQhrHnO7Wr4KqI 3uI9HAvqoInKBenFvvNu7B0EueAHYLNN5jjHIrFyNI+7/OUYxJBwQQQ1Rjn7PkRvqG X6Zq6xCjO8RyQs9L+RVxi5UWgavJnBdLsnmcsf5s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728565AbgHHXmo (ORCPT ); Sat, 8 Aug 2020 19:42:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:55394 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727797AbgHHXkH (ORCPT ); Sat, 8 Aug 2020 19:40:07 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC48120825; Sat, 8 Aug 2020 23:40:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596930006; bh=Ugj656t5RRt2/JcPvMMlruvQsjZtitRhzSD+95JsPLw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZHl54+v0rSLO0w+llkMth3n4bUIwE5C3b8lX4jwU3ZL1b7YoPro2yNq7VS7yqxmAr oOof8eJ5hyor+4O/59Rszh+60tjlwGSv12w83oW+rHPxVs9QN4SYf4wPRaxgCK1fSp edye+H6o9wwpGbTXA1nQBMC03cajvHmtyPSqemJI= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Lu Wei , Hulk Robot , Andy Shevchenko , Sasha Levin , platform-driver-x86@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 16/21] platform/x86: intel-vbtn: Fix return value check in check_acpi_dev() Date: Sat, 8 Aug 2020 19:39:36 -0400 Message-Id: <20200808233941.3619277-16-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200808233941.3619277-1-sashal@kernel.org> References: <20200808233941.3619277-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lu Wei [ Upstream commit 64dd4a5a7d214a07e3d9f40227ec30ac8ba8796e ] In the function check_acpi_dev(), if it fails to create platform device, the return value is ERR_PTR() or NULL. Thus it must use IS_ERR_OR_NULL() to check return value. Fixes: 332e081225fc ("intel-vbtn: new driver for Intel Virtual Button") Reported-by: Hulk Robot Signed-off-by: Lu Wei Signed-off-by: Andy Shevchenko Signed-off-by: Sasha Levin --- drivers/platform/x86/intel-vbtn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c index d122f33d43acb..c7c8b432c163f 100644 --- a/drivers/platform/x86/intel-vbtn.c +++ b/drivers/platform/x86/intel-vbtn.c @@ -272,7 +272,7 @@ check_acpi_dev(acpi_handle handle, u32 lvl, void *context, void **rv) return AE_OK; if (acpi_match_device_ids(dev, ids) == 0) - if (acpi_create_platform_device(dev, NULL)) + if (!IS_ERR_OR_NULL(acpi_create_platform_device(dev, NULL))) dev_info(&dev->dev, "intel-vbtn: created platform device\n"); -- 2.25.1