From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4144C433E0 for ; Sat, 8 Aug 2020 23:43:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 883612053B for ; Sat, 8 Aug 2020 23:43:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596930212; bh=B9FMDVvr3fPuFO0rvt9cDBfcrTv/H4aJ3IcGv2fBJSs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=MqHckGGxV3LPPrCjMl+ubWER8Wtze9YP5TR3/QNnDsp2GLtyvNs6tjV1J8SZs3VPa 4XRxF45p1Uv2j6UbS0NLcHTan6qyIy0oMupZmUCxQBI87FuW+gO8E6gepe+sHpiu1v DuDP62owFe6dc7Jt3PCWODCAKJnsiLtbN18oETNA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727931AbgHHXnb (ORCPT ); Sat, 8 Aug 2020 19:43:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:54728 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728629AbgHHXjq (ORCPT ); Sat, 8 Aug 2020 19:39:46 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2F79C20791; Sat, 8 Aug 2020 23:39:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596929985; bh=B9FMDVvr3fPuFO0rvt9cDBfcrTv/H4aJ3IcGv2fBJSs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fkR4vWx58WRLXwhTi6qX3ITAp/ZoUIovWJXCgwNy87bXYZy1KM0YfSrQV8dAERxmt 32b6ODHzuNXc3ICGU5fmM77zLoT93jsLfUUPxL1SRWlDwgqFp01saltq/Ct8xWQs/V 2fI2rBsaH9ukHESOX1p4a6ckRStq6u3mrZvHvfa0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Peng Liu , Peter Zijlstra , Vincent Guittot , Valentin Schneider , Sasha Levin Subject: [PATCH AUTOSEL 4.19 03/21] sched: correct SD_flags returned by tl->sd_flags() Date: Sat, 8 Aug 2020 19:39:23 -0400 Message-Id: <20200808233941.3619277-3-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200808233941.3619277-1-sashal@kernel.org> References: <20200808233941.3619277-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peng Liu [ Upstream commit 9b1b234bb86bcdcdb142e900d39b599185465dbb ] During sched domain init, we check whether non-topological SD_flags are returned by tl->sd_flags(), if found, fire a waning and correct the violation, but the code failed to correct the violation. Correct this. Fixes: 143e1e28cb40 ("sched: Rework sched_domain topology definition") Signed-off-by: Peng Liu Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Vincent Guittot Reviewed-by: Valentin Schneider Link: https://lkml.kernel.org/r/20200609150936.GA13060@iZj6chx1xj0e0buvshuecpZ Signed-off-by: Sasha Levin --- kernel/sched/topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 74b694392f2fd..f58efa5cc6474 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -1098,7 +1098,7 @@ sd_init(struct sched_domain_topology_level *tl, sd_flags = (*tl->sd_flags)(); if (WARN_ONCE(sd_flags & ~TOPOLOGY_SD_FLAGS, "wrong sd_flags in topology description\n")) - sd_flags &= ~TOPOLOGY_SD_FLAGS; + sd_flags &= TOPOLOGY_SD_FLAGS; *sd = (struct sched_domain){ .min_interval = sd_weight, -- 2.25.1