From: Jonathan Cameron <jic23@kernel.org>
To: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Cc: Michael Walle <michael@walle.cc>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Simon Xue <xxm@rock-chips.com>
Subject: Re: [PATCH] iio: adc: rockchip_saradc: select IIO_TRIGGERED_BUFFER
Date: Sun, 9 Aug 2020 12:52:25 +0100 [thread overview]
Message-ID: <20200809125225.5cddd324@archlinux> (raw)
In-Reply-To: <2468442.jk0zRepj8P@diego>
On Mon, 03 Aug 2020 13:59:12 +0200
Heiko Stuebner <heiko.stuebner@theobroma-systems.com> wrote:
> Am Montag, 3. August 2020, 10:30:01 CEST schrieb Michael Walle:
> > The kernel fails to compile due to undefined reference to
> > devm_iio_triggered_buffer_setup() if IIO_TRIGGERED_BUFFER is not
> > enabled. The original patch [1] had this dependency. But somehow it
> > didn't make it into the kernel tree. Re-add it.
> >
> > [1] https://lore.kernel.org/lkml/20200623233011.2319035-3-heiko@sntech.de/
> >
> > Fixes: 4e130dc7b413 ("iio: adc: rockchip_saradc: Add support iio buffers")
> > Signed-off-by: Michael Walle <michael@walle.cc>
>
> Reviewed-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
>
> > ---
> > drivers/iio/adc/Kconfig | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> > index 66d9cc073157..d94dc800b842 100644
> > --- a/drivers/iio/adc/Kconfig
> > +++ b/drivers/iio/adc/Kconfig
> > @@ -865,6 +865,8 @@ config ROCKCHIP_SARADC
> > tristate "Rockchip SARADC driver"
> > depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
> > depends on RESET_CONTROLLER
> > + select IIO_BUFFER
> > + select IIO_TRIGGERED_BUFFER
> > help
> > Say yes here to build support for the SARADC found in SoCs from
> > Rockchip.
> >
>
>
>
>
next prev parent reply other threads:[~2020-08-09 11:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 8:30 [PATCH] iio: adc: rockchip_saradc: select IIO_TRIGGERED_BUFFER Michael Walle
2020-08-03 11:59 ` Heiko Stuebner
2020-08-09 11:52 ` Jonathan Cameron [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-08-28 17:42 [PATCH] iio: adc: rockchip_saradc: Select IIO_TRIGGERED_BUFFER Alexandru Elisei
2020-08-29 14:57 ` Jonathan Cameron
2020-08-30 9:26 ` Alexandru Elisei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200809125225.5cddd324@archlinux \
--to=jic23@kernel.org \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=pmeerw@pmeerw.net \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox