From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, lkp@lists.01.org,
linux-kernel@vger.kernel.org,
kernel test robot <rong.a.chen@intel.com>
Subject: Re: [PATCH nf] netfilter: nft_compat: remove flush counter optimization
Date: Mon, 10 Aug 2020 13:03:51 +0200 [thread overview]
Message-ID: <20200810110351.GA1613@salvia> (raw)
In-Reply-To: <20200809182801.9315-1-fw@strlen.de>
On Sun, Aug 09, 2020 at 08:28:01PM +0200, Florian Westphal wrote:
> WARNING: CPU: 1 PID: 16059 at lib/refcount.c:31 refcount_warn_saturate+0xdf/0xf
> [..]
> __nft_mt_tg_destroy+0x42/0x50 [nft_compat]
> nft_target_destroy+0x63/0x80 [nft_compat]
> nf_tables_expr_destroy+0x1b/0x30 [nf_tables]
> nf_tables_rule_destroy+0x3a/0x70 [nf_tables]
> nf_tables_exit_net+0x186/0x3d0 [nf_tables]
>
> Happens when a compat expr is destoyed from abort path.
> There is no functional impact; after this work queue is flushed
> unconditionally if its pending.
>
> This removes the waitcount optimization. Test of repeated
> iptables-restore of a ~60k kubernetes ruleset doesn't indicate
> a slowdown. In case the counter is needed after all for some workloads
> we can revert this and increment the refcount for the
> != NFT_PREPARE_TRANS case to avoid the increment/decrement imbalance.
>
> While at it, also flush for match case, this was an oversight
> in the original patch.
Applied, thanks.
prev parent reply other threads:[~2020-08-10 11:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200809063030.GA1538@shao2-debian>
2020-08-09 18:28 ` [PATCH nf] netfilter: nft_compat: remove flush counter optimization Florian Westphal
2020-08-10 11:03 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200810110351.GA1613@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@lists.01.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=rong.a.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox