From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: David Ahern <dsahern@kernel.org>,
namhyung@kernel.org, linux-kernel@vger.kernel.org,
jolsa@kernel.org
Subject: Re: [PATCH 1/2] perf sched: Prefer sched_waking event when it exists
Date: Mon, 10 Aug 2020 13:22:28 -0300 [thread overview]
Message-ID: <20200810162228.GB4527@kernel.org> (raw)
In-Reply-To: <d1e7bc58-122e-5e33-9f7c-d0cdfe4bb9b2@gmail.com>
Em Fri, Aug 07, 2020 at 01:50:47PM -0600, David Ahern escreveu:
> On 8/7/20 1:43 PM, Arnaldo Carvalho de Melo wrote:
> >> @@ -2958,9 +2967,10 @@ static int timehist_check_attr(struct perf_sched *sched,
> >>
> >> static int perf_sched__timehist(struct perf_sched *sched)
> >> {
> >> - const struct evsel_str_handler handlers[] = {
> >> + struct evsel_str_handler handlers[] = {
> >> { "sched:sched_switch", timehist_sched_switch_event, },
> >> { "sched:sched_wakeup", timehist_sched_wakeup_event, },
> >> + { "sched:sched_waking", timehist_sched_wakeup_event, },
> >> { "sched:sched_wakeup_new", timehist_sched_wakeup_event, },
> >> };
> >> const struct evsel_str_handler migrate_handlers[] = {
> >> @@ -3018,6 +3028,11 @@ static int perf_sched__timehist(struct perf_sched *sched)
> >>
> >> setup_pager();
> >>
> >> + /* prefer sched_waking if it is captured */
> >> + if (perf_evlist__find_tracepoint_by_name(session->evlist,
> >> + "sched:sched_waking"))
> >> + handlers[1].handler = timehist_sched_wakeup_ignore;
> >> +
> >
> >
> > ouch, can't we figure out if its present and then don't ask for the
> > wakeup one to be recorded?
> >
>
> This is the analysis side. If someone recorded with sched:* we do not
> want to analyze both sched_wakeup and sched_waking. Rather, it should
> prefer the latter and ignore the former.
Right you are, thans for the explanation, I should've noticed that :)
- Arnaldoi
next prev parent reply other threads:[~2020-08-10 16:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 16:48 [PATCH 1/2] perf sched: Prefer sched_waking event when it exists David Ahern
2020-08-07 19:43 ` Arnaldo Carvalho de Melo
2020-08-07 19:50 ` David Ahern
2020-08-10 16:22 ` Arnaldo Carvalho de Melo [this message]
2020-08-11 6:42 ` Namhyung Kim
2020-08-12 12:19 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200810162228.GB4527@kernel.org \
--to=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox