From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62801C433DF for ; Mon, 10 Aug 2020 19:17:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39C1E2080C for ; Mon, 10 Aug 2020 19:17:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597087064; bh=O9Hex2PI3iQ6/NXORTRno+6ERGMI/L7zK73tXL6N1SE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=D0KBFjAYNfRwxbH3c3CkLpw0ygRdOlePlPZzLyYPwEEaMB2k5+BOK56Jd3MpeIGRk sRT8ndRv11tqJYQyw2cQgox/UXMGqoDMwPW+dFT+huFDmFv/f8zDfGQnyCoedjsKgX H4qASmVnAEkvxITycG3ubDg/M/4scY5q3ICoY/uM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729371AbgHJTOS (ORCPT ); Mon, 10 Aug 2020 15:14:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:46072 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729966AbgHJTOM (ORCPT ); Mon, 10 Aug 2020 15:14:12 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 508F522C9E; Mon, 10 Aug 2020 19:14:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597086851; bh=O9Hex2PI3iQ6/NXORTRno+6ERGMI/L7zK73tXL6N1SE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HPsYT7GgHOsZULDJNhBZAazPFcj0rQlQsQ0WhwFLHjT2udATuWbD+ehxXMXNWSuwq R/22N7XFcYsqsm1jzfr2sQJc231Ci5DpIoNH3j/ysMCHDHQGyE5aISq6eGCcU8RlWf rP+yqiEG784NvNEUMtWNg6j1jFn6Fp7cKE1XB6fQ= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Danesh Petigara , Al Cooper , Florian Fainelli , Felipe Balbi , Sasha Levin , linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 18/22] usb: bdc: Halt controller on suspend Date: Mon, 10 Aug 2020 15:13:40 -0400 Message-Id: <20200810191345.3795166-18-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200810191345.3795166-1-sashal@kernel.org> References: <20200810191345.3795166-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Danesh Petigara [ Upstream commit 5fc453d7de3d0c345812453823a3a56783c5f82c ] GISB bus error kernel panics have been observed during S2 transition tests on the 7271t platform. The errors are a result of the BDC interrupt handler trying to access BDC register space after the system's suspend callbacks have completed. Adding a suspend hook to the BDC driver that halts the controller before S2 entry thus preventing unwanted access to the BDC register space during this transition. Signed-off-by: Danesh Petigara Signed-off-by: Al Cooper Acked-by: Florian Fainelli Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/bdc/bdc_core.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c index 2660cc2e42a08..58ba04d858bab 100644 --- a/drivers/usb/gadget/udc/bdc/bdc_core.c +++ b/drivers/usb/gadget/udc/bdc/bdc_core.c @@ -613,9 +613,14 @@ static int bdc_remove(struct platform_device *pdev) static int bdc_suspend(struct device *dev) { struct bdc *bdc = dev_get_drvdata(dev); + int ret; - clk_disable_unprepare(bdc->clk); - return 0; + /* Halt the controller */ + ret = bdc_stop(bdc); + if (!ret) + clk_disable_unprepare(bdc->clk); + + return ret; } static int bdc_resume(struct device *dev) -- 2.25.1