From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAE68C433E3 for ; Mon, 10 Aug 2020 19:17:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C5392080C for ; Mon, 10 Aug 2020 19:17:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597087052; bh=aLwNQpIz+zkPVPgfGML/oL14Z+6IMWC7eDFdKkDNAdI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=0uP0+SksVtlNVRvLCgkpsIXQ0txGEAas4wSOJfxZMWdyDEf6iGmXRJnq2D+j+kCVo h6nNYgsgH/WAM0ghXfbKJC+Cb5+/xIlWIeRys/qY9szOAhS0gyugtyuZDSKDbG/Chj G4myPev9hfn9m2Ka6m33iQErSfIQVm93YBPVIyg8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730001AbgHJTOY (ORCPT ); Mon, 10 Aug 2020 15:14:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:46166 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729972AbgHJTOO (ORCPT ); Mon, 10 Aug 2020 15:14:14 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0F11B22B49; Mon, 10 Aug 2020 19:14:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597086853; bh=aLwNQpIz+zkPVPgfGML/oL14Z+6IMWC7eDFdKkDNAdI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NMSoKJqRaDJQI0fUGqB50YpeYdsCPlfHtIz0Ju9I77ryeEyEZXlF559StBrDSo7D7 wZwiC9/nrXdm7M0x//f7rSyR/jjWELS+iAgtkkyB4ozte4y6rDbNpr8O6C9MpGQGcs 7eEqNqXLdpyC7Cdz6qkA0X4oCIikOUT6V0/8BbCM= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jim Cromie , jbaron@akamai.com, Greg Kroah-Hartman , Sasha Levin Subject: [PATCH AUTOSEL 4.14 20/22] dyndbg: prefer declarative init in caller, to memset in callee Date: Mon, 10 Aug 2020 15:13:42 -0400 Message-Id: <20200810191345.3795166-20-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200810191345.3795166-1-sashal@kernel.org> References: <20200810191345.3795166-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jim Cromie [ Upstream commit 9c9d0acbe2793315fa6945a19685ad2a51fb281b ] ddebug_exec_query declares an auto var, and passes it to ddebug_parse_query, which memsets it before using it. Drop that memset, instead initialize the variable in the caller; let the compiler decide how to do it. Acked-by: Signed-off-by: Jim Cromie Link: https://lore.kernel.org/r/20200719231058.1586423-10-jim.cromie@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- lib/dynamic_debug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 91c451e0f4741..a95557f9e8d55 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -325,7 +325,6 @@ static int ddebug_parse_query(char *words[], int nwords, pr_err("expecting pairs of match-spec \n"); return -EINVAL; } - memset(query, 0, sizeof(*query)); if (modname) /* support $modname.dyndbg= */ @@ -443,7 +442,7 @@ static int ddebug_parse_flags(const char *str, unsigned int *flagsp, static int ddebug_exec_query(char *query_string, const char *modname) { unsigned int flags = 0, mask = 0; - struct ddebug_query query; + struct ddebug_query query = {}; #define MAXWORDS 9 int nwords, nfound; char *words[MAXWORDS]; -- 2.25.1