From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Prashant Malani <pmalani@chromium.org>,
"Shaikh, Azhar" <azhar.shaikh@intel.com>
Cc: "bleung@chromium.org" <bleung@chromium.org>,
"enric.balletbo@collabora.com" <enric.balletbo@collabora.com>,
"groeck@chromium.org" <groeck@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Patel, Utkarsh H" <utkarsh.h.patel@intel.com>,
"Bowman, Casey G" <casey.g.bowman@intel.com>,
"Mani, Rajmohan" <rajmohan.mani@intel.com>
Subject: Re: [PATCH v2 2/2] platform/chrome: cros_ec_typec: Avoid setting usb role during disconnect
Date: Tue, 11 Aug 2020 16:07:03 +0300 [thread overview]
Message-ID: <20200811130703.GA627773@kuha.fi.intel.com> (raw)
In-Reply-To: <CACeCKaeLmVudhssvnYrQGmnJiD-byW8jOas1QKyQj4gg0=sC4A@mail.gmail.com>
Hi,
On Thu, Aug 06, 2020 at 11:39:08AM -0700, Prashant Malani wrote:
> I would suggest:
> - Merging Patch 1 (role set correction) and Patch 2 (moving the
> usb_role_switch_set_role() inside cros_typec_configure_mux()
> *but* keep it at the end to preserve existing ordering) into 1 patch.
> - Add another patch which re-orders the calls and which in the commit
> message lists out all the reasons why this re-ordering
> needs to be done.
>
> Doing the above will help keep better track of why the changes were made.
So Azhar can you please prepare v3?
thanks,
--
heikki
next prev parent reply other threads:[~2020-08-11 13:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 22:56 [PATCH v2 0/2] TypeC Connector Class driver improvements Azhar Shaikh
2020-07-30 22:56 ` [PATCH v2 1/2] platform/chrome: cros_ec_typec: Send enum values to usb_role_switch_set_role() Azhar Shaikh
2020-07-30 22:59 ` Prashant Malani
2020-07-30 23:02 ` Shaikh, Azhar
2020-07-30 23:04 ` Prashant Malani
2020-07-30 23:14 ` Shaikh, Azhar
2020-07-30 23:18 ` Prashant Malani
2020-07-30 22:56 ` [PATCH v2 2/2] platform/chrome: cros_ec_typec: Avoid setting usb role during disconnect Azhar Shaikh
2020-07-30 23:02 ` Prashant Malani
2020-07-30 23:06 ` Shaikh, Azhar
2020-07-30 23:25 ` Prashant Malani
2020-08-05 19:22 ` Shaikh, Azhar
2020-08-05 19:37 ` Prashant Malani
2020-08-05 20:28 ` Shaikh, Azhar
2020-08-06 0:57 ` Prashant Malani
2020-08-06 11:39 ` Heikki Krogerus
2020-08-06 18:39 ` Prashant Malani
2020-08-11 13:07 ` Heikki Krogerus [this message]
2020-08-11 19:39 ` Shaikh, Azhar
2020-08-05 9:09 ` [PATCH v2 0/2] TypeC Connector Class driver improvements Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200811130703.GA627773@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=azhar.shaikh@intel.com \
--cc=bleung@chromium.org \
--cc=casey.g.bowman@intel.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=rajmohan.mani@intel.com \
--cc=utkarsh.h.patel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox