Re: [PATCH 02/33] spmi, regulator, mfd: add drivers for hikey970 SPMI PMIC

Mauro Carvalho Chehab
2020-08-11T16:35:18Z

Em Tue, 11 Aug 2020 17:15:39 +0100
Mark Brown <broonie@kernel.org> escreveu:

> On Tue, Aug 11, 2020 at 06:08:37PM +0200, Mauro Carvalho Chehab wrote:
> > Mark Brown <broonie@kernel.org> escreveu:
>
> > > This is a single patch for three subsystems, please split it into per
> > > subsystem patches.
>
> > Ok, I'll split on a next version.
>
> > Yet, it would be good to have all tree drivers applied via the same tree,
> > as those drivers are needed altogether in order for this PMIC to work:
>
> This is completely normal for MFD drivers, it's still much easier to
> review things if individual subsystem maintainers can easily get to the
> code for their subsystem, any Reviewed-bys or whatever can be sensibly
> applies to relevant code and ideally people can apply patches as they're
> ready if there's no build time dependencies or Kconfig symbols which
> prevent build without the dependencies being merged.

Ok. I'll split it into three series.

Before posting the next version, it would be nice to have some feedback
specially at the DT documentation patch:

https://lore.kernel.org/lkml/176043f329dfa9889f014feec04e7e1553077873.1597160086.git.mchehab+huawei@kernel.org/T/#u

as any changes there will need to be reflected on the other patches
from this series.

Btw, despite being 3 drivers, I added only two DT docs, as the
regulator description is done together with the PMIC one.

Thanks,
Mauro