From: peterz@infradead.org
To: Christoph Hellwig <hch@infradead.org>
Cc: Jacob Wen <jian.w.wen@oracle.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: insert a general SMP memory barrier before wake_up_bit()
Date: Thu, 13 Aug 2020 13:40:50 +0200 [thread overview]
Message-ID: <20200813114050.GW2674@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200813073115.GA15436@infradead.org>
On Thu, Aug 13, 2020 at 08:31:15AM +0100, Christoph Hellwig wrote:
> On Thu, Aug 13, 2020 at 10:44:38AM +0800, Jacob Wen wrote:
> > wake_up_bit() uses waitqueue_active() that needs the explicit smp_mb().
>
> Sounds like the barrier should go into wake_up_bit then..
Oh, thanks for reminding me..
https://lkml.kernel.org/r/20190624165012.GH3436@hirez.programming.kicks-ass.net
I'll try and get back to that.
next prev parent reply other threads:[~2020-08-13 11:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200813024438.13170-1-jian.w.wen@oracle.com>
2020-08-13 7:31 ` [PATCH] block: insert a general SMP memory barrier before wake_up_bit() Christoph Hellwig
2020-08-13 7:46 ` Jacob Wen
2020-08-13 11:40 ` peterz [this message]
2020-08-13 12:00 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813114050.GW2674@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=hch@infradead.org \
--cc=jian.w.wen@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox