From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BCA3C433E1 for ; Thu, 13 Aug 2020 15:44:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 668AE20855 for ; Thu, 13 Aug 2020 15:44:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597333493; bh=n+lRf4d5ROJJHRRF+9tZK3toZHtlbpLJVRPOxkuH/z8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=i3834wXTnutsnRGniXs8hHAA0qlgZNUJmY8eqnO+0sGlLQ6lfirdi9Fj9Oy9jfeaF zSW9Ho/p+jNGTGohAwXZVhW2wm2tLrUQ79Ws6MT+JciU8R69ODnJmFjNnmxtCXpQ9X C7NgFg2lA2C7dpc06+Qdt991fiwiTDcdxBQC6Kyo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726591AbgHMPow (ORCPT ); Thu, 13 Aug 2020 11:44:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:45830 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726131AbgHMPov (ORCPT ); Thu, 13 Aug 2020 11:44:51 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC5DD20829; Thu, 13 Aug 2020 15:44:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597333491; bh=n+lRf4d5ROJJHRRF+9tZK3toZHtlbpLJVRPOxkuH/z8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lKnA/zVLUdkO1TJD7+L5mhYBc70cMDkgdLPUn9ffKVSLOfUZv2cftQsPNjMY7sFcR hTn976Kp6Chv4Md7iyAUoFoeZpIcMbrSK6O5sPcuRizWoFrDOnHXjf8xu01CRhysoo VsKea1izNepj0If4Xr3fFcYV0g+ELVPGho25swa0= Date: Thu, 13 Aug 2020 16:44:23 +0100 From: Mark Brown To: Jiaxin Yu Cc: matthias.bgg@gmail.com, robh+dt@kernel.org, tiwai@suse.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, howie.huang@mediatek.com, tzungbi@google.com, eason.yen@mediatek.com, shane.chien@mediatek.com Subject: Re: [PATCH v2 1/2] ASoC: mediatek: mt6359: add codec driver Message-ID: <20200813154423.GC5541@sirena.org.uk> References: <1597028754-7732-1-git-send-email-jiaxin.yu@mediatek.com> <1597028754-7732-2-git-send-email-jiaxin.yu@mediatek.com> <20200810185933.GI6438@sirena.org.uk> <1597217353.23246.45.camel@mhfsdcap03> <20200812120537.GA5545@sirena.org.uk> <1597333200.23246.68.camel@mhfsdcap03> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lMM8JwqTlfDpEaS6" Content-Disposition: inline In-Reply-To: <1597333200.23246.68.camel@mhfsdcap03> X-Cookie: Your mileage may vary. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --lMM8JwqTlfDpEaS6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 13, 2020 at 11:40:00PM +0800, Jiaxin Yu wrote: > On Wed, 2020-08-12 at 13:05 +0100, Mark Brown wrote: > > These functions are exported for other drivers to use rather than > > something done internally by the driver - if this were internal to the > > driver it'd not be a big deal but when it's for use by another driver > > it'd be better to go through standard interfaces. > Can we move this part of the operation to the codec dai driver ops, such > as .startup and .shutdown? Because originally these functions are > exported to machine driver's dai_link .startup and .shutdown ops. If it's internal to the driver sure. > > So this needs the SoC to do something as part of callibration? > Yes, the side of MTKAIF in SoC part named adda, we need config it before > calibration. We will also upstream machine/platform driver that use this > codec driver later. It would probably be better to just leave this out for now then add the required bits to the CODEC driver as part of a patch series that also adds the machine driver that uses it so it's clear how it all fits together. It sounds like it should be fine but this'd be easier to review. --lMM8JwqTlfDpEaS6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl81X9cACgkQJNaLcl1U h9AgEgf8CMREa84vouym5KtpM1No5HSGwGI5+EJTOUWF8vPkS1W3IuMv5ZoWeuvF kOFsj5OQHliWGiQbI+HI5X6H7cruLsvVPBoxUg7hHx9n7zfz25IbaTiuk5/QpTJ2 id7eshXQ5TSPfRJ4WQrcePCn07HCnvI5HkBxw3L18IBjw/z34TCPoA8cVh0SqLnS ecTT2uq7Yjd+1OxvjHVlMsw4GE/b+JXk/IOScAFNiVe/ofYzzNP04VgJNA7f20wA +UAs84bO5bfuqtrzbtDTRxu6P3p5Gw4d3zJuVLiqD+W481IeUVo/I5LcGFkDG+5e 20ANMcyLw+bJyzovtx+vqIMLy6AM9w== =v+hX -----END PGP SIGNATURE----- --lMM8JwqTlfDpEaS6--