public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Joerg Roedel <jroedel@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Borislav Petkov <bp@alien8.de>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL] x86/mm changes for v5.9
Date: Thu, 13 Aug 2020 21:30:08 +0200	[thread overview]
Message-ID: <20200813193008.GB2338781@gmail.com> (raw)
In-Reply-To: <20200807084728.GA29510@suse.de>


* Joerg Roedel <jroedel@suse.de> wrote:

> On Thu, Aug 06, 2020 at 11:20:19PM +0200, Ingo Molnar wrote:
> > I've reverted it in x86/urgent as well earlier today, can send you 
> > that tree right now if you prefer that route.
> 
> I sent a fix for preallocate_vmalloc_pages() to correctly pre-allocate
> the vmalloc PGD entries. I verified that it works and that
> swapper_pg_dir contains the correct entries now. This should also fix
> the issue Jason is seeing.

Thanks!

There's one thing left to do. Linus has reverted the patch which 
exposed this bug:

  7b4ea9456dd3: ("Revert "x86/mm/64: Do not sync vmalloc/ioremap mappings"")

and has applied your fix:

  995909a4e22b: ("x86/mm/64: Do not dereference non-present PGD entries")

I think now we can re-apply the original commit:

  8bb9bf242d1f: ("x86/mm/64: Do not sync vmalloc/ioremap mappings")

Mind re-sending it, with an updated changelog that explains why it's 
now truly safe?

Would be tentatively scheduled for v5.10 though, we've had enough 
excitement in this area for v5.9 I think. :-/

> Sorry for screwing this up :-(

No problem, and it was my fault too: I sent 8bb9bf242d1f to Linus too 
quickly, just 7 days after applying it - x86/mm patches usually need a 
few weeks of testing.

Thanks,

	Ingo

  reply	other threads:[~2020-08-13 19:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-03 19:03 [GIT PULL] x86/mm changes for v5.9 Ingo Molnar
2020-08-04  0:50 ` pr-tracker-bot
2020-08-05 11:03 ` Jason A. Donenfeld
2020-08-05 17:05   ` Linus Torvalds
2020-08-06 13:10     ` Ingo Molnar
2020-08-06 18:57       ` Joerg Roedel
2020-08-06 19:02         ` Linus Torvalds
2020-08-06 19:23           ` Joerg Roedel
2020-08-06 19:42             ` Linus Torvalds
2020-08-06 19:57               ` Tejun Heo
2020-08-07  9:53             ` Jason A. Donenfeld
2020-08-06 21:20           ` Ingo Molnar
2020-08-07  8:47             ` Joerg Roedel
2020-08-13 19:30               ` Ingo Molnar [this message]
2020-08-13 19:38                 ` Linus Torvalds
2020-08-14 14:26                 ` Joerg Roedel
2020-08-06 22:56   ` Joerg Roedel
2020-08-06 23:12     ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200813193008.GB2338781@gmail.com \
    --to=mingo@kernel.org \
    --cc=Jason@zx2c4.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=jroedel@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox