public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jiang Ying <jiangying8582@126.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, wanglong19@meituan.com,
	heguanjun@meituan.com, jack@suse.cz
Subject: Re: [PATCH v4] ext4: fix direct I/O read error
Date: Fri, 14 Aug 2020 09:04:04 +0100	[thread overview]
Message-ID: <20200814080404.GA14135@infradead.org> (raw)
In-Reply-To: <1596613234-174664-1-git-send-email-jiangying8582@126.com>

On Wed, Aug 05, 2020 at 03:40:34PM +0800, Jiang Ying wrote:
> This patch is used to fix ext4 direct I/O read error when
> the read size is not aligned with block size.
> 
> Then, I will use a test to explain the error.
> 
> (1) Make a file that is not aligned with block size:
> 	$dd if=/dev/zero of=./test.jar bs=1000 count=3
> 
> (2) I wrote a source file named "direct_io_read_file.c" as following:

Can you please add your reproducer to xfstests?

Thanks!

  reply	other threads:[~2020-08-14  8:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-05  7:40 [PATCH v4] ext4: fix direct I/O read error Jiang Ying
2020-08-14  8:04 ` Christoph Hellwig [this message]
2020-08-14  8:38   ` 姜迎
  -- strict thread matches above, loose matches on Subject: below --
2020-08-05  7:57 Jiang Ying
2020-08-05  8:51 ` Jan Kara
2020-08-05 14:29   ` Greg KH
2020-08-06  1:19   ` Sasha Levin
2020-08-06  1:52     ` 姜迎

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200814080404.GA14135@infradead.org \
    --to=hch@infradead.org \
    --cc=adilger.kernel@dilger.ca \
    --cc=heguanjun@meituan.com \
    --cc=jack@suse.cz \
    --cc=jiangying8582@126.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=wanglong19@meituan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox