From: Vincent Whitchurch <vincent.whitchurch@axis.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: John Ogness <john.ogness@linutronix.de>,
"jbaron@akamai.com" <jbaron@akamai.com>,
"mingo@redhat.com" <mingo@redhat.com>, kernel <kernel@axis.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH] dynamic debug: allow printing to trace event
Date: Fri, 14 Aug 2020 15:34:15 +0200 [thread overview]
Message-ID: <20200814133415.nbkehai2vp765an5@axis.com> (raw)
In-Reply-To: <20200723112644.7759f82f@oasis.local.home>
On Thu, Jul 23, 2020 at 05:26:44PM +0200, Steven Rostedt wrote:
> On Thu, 23 Jul 2020 12:57:35 +0200
> Vincent Whitchurch <vincent.whitchurch@axis.com> wrote:
>
> > Would it be acceptable to just use a fixed size for the event? At least
> > for my own debugging use cases it's preferable to just have to increase
> > the trace buffer size in case it's insufficient, rather than to have to
> > restort to one-off debugging code.
>
> There's two other options.
>
> Option 1, is to allocate 256 bytes times 4 (in case of interruption,
> where you have a separate buffer for every context - normal, softirq,
> irq, nmi), and use it like I do for stack traces in the latest kernel
> (see __ftrace_stack_trace() in kernel/trace/trace.c)
>
> Option 2, would be to use trace_array_vprintk(), but you need to create
> your own instance to do so to keep from messing with the top level buffer.
Thanks for the suggestions, I've sent out a v2 implementing option 1:
https://lore.kernel.org/lkml/20200814133151.7759-1-vincent.whitchurch@axis.com/
next prev parent reply other threads:[~2020-08-14 13:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 14:11 [PATCH] dynamic debug: allow printing to trace event Vincent Whitchurch
2020-07-21 21:30 ` Steven Rostedt
2020-07-22 11:37 ` Sergey Senozhatsky
2020-07-22 13:52 ` John Ogness
2020-07-22 14:49 ` Vincent Whitchurch
2020-07-22 15:28 ` Steven Rostedt
2020-07-23 10:57 ` Vincent Whitchurch
2020-07-23 15:26 ` Steven Rostedt
2020-08-14 13:34 ` Vincent Whitchurch [this message]
2020-07-22 15:25 ` Steven Rostedt
2020-07-23 14:02 ` John Ogness
2020-07-23 14:20 ` John Ogness
2020-07-23 15:39 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814133415.nbkehai2vp765an5@axis.com \
--to=vincent.whitchurch@axis.com \
--cc=corbet@lwn.net \
--cc=jbaron@akamai.com \
--cc=john.ogness@linutronix.de \
--cc=kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox