From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D5B3C433E3 for ; Fri, 14 Aug 2020 15:05:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37AF820774 for ; Fri, 14 Aug 2020 15:05:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="Q+k/cLCC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728603AbgHNPFl (ORCPT ); Fri, 14 Aug 2020 11:05:41 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:40688 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728347AbgHNPFg (ORCPT ); Fri, 14 Aug 2020 11:05:36 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1597417536; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=7FCVfLxxmii9ov0dCHs81K5wnCBYwV2wRwZYNb84Q9E=; b=Q+k/cLCC5QtV2zhxJq7yjef/8EDcvnswMDLr0EtWcA+2iVXQLgEgWtfAwl1n6J64TtzoVDTT yGN+j1FHNu5xyYWKc06ouUr0bUBrhEbfJOgnWE6tY1uQAhWLA4K9BOBIiiqoUuBaIyAZVK9U wOEP4W4TuC0dc7zU/2qvYSTFahE= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 5f36a8331e4d3989d476e079 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 14 Aug 2020 15:05:23 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id C0936C43391; Fri, 14 Aug 2020 15:05:22 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 78CDAC433C9; Fri, 14 Aug 2020 15:05:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 78CDAC433C9 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 7/7] ath: drop unnecessary list_empty From: Kalle Valo In-Reply-To: <1595761112-11003-8-git-send-email-Julia.Lawall@inria.fr> References: <1595761112-11003-8-git-send-email-Julia.Lawall@inria.fr> To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200814150522.C0936C43391@smtp.codeaurora.org> Date: Fri, 14 Aug 2020 15:05:22 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Julia Lawall wrote: > list_for_each_entry{_safe} is able to handle an empty list. > The only effect of avoiding the loop is not initializing the > index variable. > Drop list_empty tests in cases where these variables are not > used. > > Note that list_for_each_entry{_safe} is defined in terms of > list_first_entry, which indicates that it should not be used on an > empty list. But in list_for_each_entry{_safe}, the element obtained > by list_first_entry is not really accessed, only the address of its > list_head field is compared to the address of the list head, so the > list_first_entry is safe. > > The semantic patch that makes this change for the list_for_each_entry > case is as follows: (http://coccinelle.lip6.fr/) > > > @@ > expression x,e; > statement S; > identifier i; > @@ > > -if (!(list_empty(x))) > list_for_each_entry(i,x,...) S > ... when != i > ? i = e > > > Signed-off-by: Julia Lawall > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 18c25b4019ca ath: drop unnecessary list_empty -- https://patchwork.kernel.org/patch/11685677/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches