From: Peter Zijlstra <peterz@infradead.org>
To: Uriel Guajardo <urielguajardojr@gmail.com>
Cc: brendanhiggins@google.com, mingo@redhat.com, will@kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, urielguajardo@google.com,
alan.maguire@oracle.com
Subject: Re: [PATCH v3] kunit: added lockdep support
Date: Fri, 14 Aug 2020 22:58:47 +0200 [thread overview]
Message-ID: <20200814205847.GK3982@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20200814205527.1833459-1-urielguajardojr@gmail.com>
On Fri, Aug 14, 2020 at 08:55:27PM +0000, Uriel Guajardo wrote:
> +
> +void kunit_check_lockdep(struct kunit *test, struct kunit_lockdep *lockdep) {
> + int saved_preempt_count = lockdep->preempt_count;
> + bool saved_debug_locks = lockdep->debug_locks;
> +
> + if (DEBUG_LOCKS_WARN_ON(preempt_count() != saved_preempt_count))
> + preempt_count_set(saved_preempt_count);
> +
> +#ifdef CONFIG_TRACE_IRQFLAGS
> + if (softirq_count())
> + current->softirqs_enabled = 0;
> + else
> + current->softirqs_enabled = 1;
> +#endif
This block is pointless. The only way to get softirq tracing out of sync
is an unbalanced local_bh_disable(), but then the above preempt_count()
test will trigger and kill IRQ tracing.
> +
> + if (saved_debug_locks && !debug_locks) {
> + kunit_set_failure(test);
> + kunit_warn(test, "Dynamic analysis tool failure from LOCKDEP.");
> + kunit_warn(test, "Further tests will have LOCKDEP disabled.");
> + }
> +}
next prev parent reply other threads:[~2020-08-14 20:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 20:55 [PATCH v3] kunit: added lockdep support Uriel Guajardo
2020-08-14 20:58 ` Peter Zijlstra [this message]
2020-08-14 21:00 ` Uriel Guajardo
2020-08-15 8:30 ` Ingo Molnar
2020-08-15 8:44 ` Peter Zijlstra
2020-08-15 9:17 ` Ingo Molnar
2020-08-17 21:00 ` Uriel Guajardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814205847.GK3982@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=alan.maguire@oracle.com \
--cc=brendanhiggins@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=urielguajardo@google.com \
--cc=urielguajardojr@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox