From: Philip Li <philip.li@intel.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Thomas Gleixner <tglx@linutronix.de>,
kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
Theodore Ts'o <tytso@mit.edu>, Jan Kara <jack@suse.cz>,
Nicolas Palix <nicolas.palix@imag.fr>
Subject: Re: [kbuild-all] Re: fs/ocfs2/suballoc.c:2430:2-8: preceding lock on line 2413
Date: Sat, 15 Aug 2020 20:52:43 +0800 [thread overview]
Message-ID: <20200815125243.GA21882@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2008142148180.2441@hadrien>
On Fri, Aug 14, 2020 at 09:52:13PM +0200, Julia Lawall wrote:
>
>
> On Fri, 14 Aug 2020, Thomas Gleixner wrote:
>
> > Julia,
> >
> > On Fri, Aug 14 2020 at 21:00, Julia Lawall wrote:
> > > On Fri, 14 Aug 2020, Thomas Gleixner wrote:
> > >> That's clearly a false positive. Is there anything what can be done to
> > >> help that cocci script here?
> > >
> > > I have a better version that needs to get pushed.
> > >
> > > But normally these pass through me. Did you get it directly from kbuild?
> >
> > Yes, because I touched the affected lines last :)
>
> Actually, that's not the point. Normally, I get all the reports on this
> case, and then I forward them if they look ok. If I forwarded something
> incorrect, then sorry about that. If the policy has changed for this rule
> to be sending the reports out directlty to the recipients, then I think it
> should be changed back. There are a lot of real bugs with lock usage, but
> there are alot of false positives too. Specifically, the rule looks for
> the case with identical if tests, but only when the branches are identical
> too.
>
> Kbuild people, can this be adjusted? Or have I misunderstood the
> situation?
Hi Julia and Thomas, pls allow us to check this further, usually all cocci
reports will be sent to kbuild@01.org for Julia to check. But there maybe
something wrong with this report. We will check the detail in next week as
we have server maintainance during the weekend.
>
> thanks,
> julia
> _______________________________________________
> kbuild-all mailing list -- kbuild-all@lists.01.org
> To unsubscribe send an email to kbuild-all-leave@lists.01.org
prev parent reply other threads:[~2020-08-15 21:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 6:11 fs/ocfs2/suballoc.c:2430:2-8: preceding lock on line 2413 kernel test robot
2020-08-14 13:32 ` Thomas Gleixner
2020-08-14 19:00 ` Julia Lawall
2020-08-14 19:40 ` Thomas Gleixner
2020-08-14 19:52 ` Julia Lawall
2020-08-15 12:52 ` Philip Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200815125243.GA21882@intel.com \
--to=philip.li@intel.com \
--cc=jack@suse.cz \
--cc=julia.lawall@inria.fr \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nicolas.palix@imag.fr \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox