From: Leon Romanovsky <leon@kernel.org>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc: kjlu@umn.edu, Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Yishai Hadas <yishaih@mellanox.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/mlx5: Fix memleak in subscribe_event_xa_alloc
Date: Sun, 16 Aug 2020 11:11:35 +0300 [thread overview]
Message-ID: <20200816081135.GG7555@unreal> (raw)
In-Reply-To: <20200815034537.9867-1-dinghao.liu@zju.edu.cn>
On Sat, Aug 15, 2020 at 11:45:37AM +0800, Dinghao Liu wrote:
> When xa_insert() fails, obj_event needs to be freed
> just like what we have done to event when xa_insert()
> fails. However, current code is returning directly
> and ends up leaking memory.
>
> Fixes: 7597385371425 ("IB/mlx5: Enable subscription for device events over DEVX")
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
> drivers/infiniband/hw/mlx5/devx.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Thanks,
Acked-by: Leon Romanovsky <leonro@nvidia.com>
parent reply other threads:[~2020-08-16 8:11 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200815034537.9867-1-dinghao.liu@zju.edu.cn>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200816081135.GG7555@unreal \
--to=leon@kernel.org \
--cc=dinghao.liu@zju.edu.cn \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox