* Re: [PATCH] IB/mlx5: Fix memleak in subscribe_event_xa_alloc
[not found] <20200815034537.9867-1-dinghao.liu@zju.edu.cn>
@ 2020-08-16 8:11 ` Leon Romanovsky
0 siblings, 0 replies; only message in thread
From: Leon Romanovsky @ 2020-08-16 8:11 UTC (permalink / raw)
To: Dinghao Liu
Cc: kjlu, Doug Ledford, Jason Gunthorpe, Yishai Hadas, linux-rdma,
linux-kernel
On Sat, Aug 15, 2020 at 11:45:37AM +0800, Dinghao Liu wrote:
> When xa_insert() fails, obj_event needs to be freed
> just like what we have done to event when xa_insert()
> fails. However, current code is returning directly
> and ends up leaking memory.
>
> Fixes: 7597385371425 ("IB/mlx5: Enable subscription for device events over DEVX")
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
> drivers/infiniband/hw/mlx5/devx.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Thanks,
Acked-by: Leon Romanovsky <leonro@nvidia.com>
^ permalink raw reply [flat|nested] only message in thread