Re: [PATCH v5 3/5] iio:temperature:mlx90632: Convert polling while loop to do-while

Andy Shevchenko
2020-08-13T11:03:46Z

On Thu, Aug 13, 2020 at 10:53 AM Crt Mori <cmo@melexis.com> wrote:
>
> Reduce number of lines and improve readability to convert polling while
> loops to do-while. The iopoll.h interface was not used, because we
> require more than 20ms timeout, because time for sensor to perform a
> measurement is around 10ms and it needs to perform measurements for each
> channel (which currently is 3).

I don't see how it prevents using iopoll.h. It uses usleep_range()
under the hood in the same way you did here, but open coded.

...

> - while (tries-- > 0) {
> + do {
> ret = regmap_read(data->regmap, MLX90632_REG_STATUS,
> &reg_status);
> if (ret < 0)
> return ret;
> - if (reg_status & MLX90632_STAT_DATA_RDY)
> - break;
> usleep_range(10000, 11000);
> - }
> + } while (!(reg_status & MLX90632_STAT_DATA_RDY) && tries--);
>
> if (tries < 0) {
> dev_err(&data->client->dev, "data not ready");

--
With Best Regards,
Andy Shevchenko