From: Marius Zachmann <mail@mariuszachmann.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Marius Zachmann <mail@mariuszachmann.de>,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] hwmon: corsair-cpro: fix ccp_probe, add delay
Date: Mon, 17 Aug 2020 09:00:40 +0200 [thread overview]
Message-ID: <20200817070040.7952-1-mail@mariuszachmann.de> (raw)
Possibly because of the changes in usbhid/hid-core.c the first
raw input report is not received during ccp_probe function and it will
timeout. I am not sure, whether this behaviour is expected after
hid_device_io_start or if I am missing something.
As a solution this adds msleep(50) to ccp_probe so that all initial
input reports can be received.
Signed-off-by: Marius Zachmann <mail@mariuszachmann.de>
---
v2:
- fix accidentally deleted comment
---
drivers/hwmon/corsair-cpro.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hwmon/corsair-cpro.c b/drivers/hwmon/corsair-cpro.c
index 591929ec217a..c04fac1d820f 100644
--- a/drivers/hwmon/corsair-cpro.c
+++ b/drivers/hwmon/corsair-cpro.c
@@ -10,6 +10,7 @@
#include <linux/bitops.h>
#include <linux/completion.h>
+#include <linux/delay.h>
#include <linux/hid.h>
#include <linux/hwmon.h>
#include <linux/kernel.h>
@@ -513,6 +514,7 @@ static int ccp_probe(struct hid_device *hdev, const struct hid_device_id *id)
init_completion(&ccp->wait_input_report);
hid_device_io_start(hdev);
+ msleep(50); /* wait before events can be received */
/* temp and fan connection status only updates when device is powered on */
ret = get_temp_cnct(ccp);
--
2.28.0
next reply other threads:[~2020-08-17 7:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 7:00 Marius Zachmann [this message]
2020-08-17 15:35 ` [PATCH v2] hwmon: corsair-cpro: fix ccp_probe, add delay [HID related] Guenter Roeck
2020-08-18 13:12 ` Marius Zachmann
2020-08-18 13:42 ` Guenter Roeck
2020-08-18 17:51 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817070040.7952-1-mail@mariuszachmann.de \
--to=mail@mariuszachmann.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox