Re: [PATCH 08/11] x86: make TASK_SIZE_MAX usable from assembly code

Christoph Hellwig
2020-08-18T19:55:42Z

On Tue, Aug 18, 2020 at 12:44:49PM -0700, Kees Cook wrote:
> On Mon, Aug 17, 2020 at 09:32:09AM +0200, Christoph Hellwig wrote:
> > For 64-bit the only hing missing was a strategic _AC, and for 32-bit we
>
> typo: thing
>
> > need to use __PAGE_OFFSET instead of PAGE_OFFSET in the TASK_SIZE
> > definition to escape the explicit unsigned long cast. This just works
> > because __PAGE_OFFSET is defined using _AC itself and thus never needs
> > the cast anyway.
>
> Shouldn't this be folded into the prior patch so there's no bisection
> problem?

I didn't see a problem bisecting, do you have something particular in
mind?