From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 257E7C433DF for ; Mon, 17 Aug 2020 12:06:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E353A2072E for ; Mon, 17 Aug 2020 12:06:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597666006; bh=vmrKUQjSbgbJ2NUuDaweXVu6j3i/PJqVtpxAZycIFWU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=s+hKu9oMSfrt3EBmbIu7oQL1yxgrDpPj0f/GKFrNAcACJBsJ2YQG3TM2D9E3lYqM1 DZtSyay/zAQVg6mQUvyQM3JmF0M6rnX4wkLxuhWrU2xKRDi3+5Bfd7pjHH8r6MnVWS 2hZt2CvRLVpywonJU0TFEbA7F9G+0Id2D3tkUVS0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728135AbgHQMGo (ORCPT ); Mon, 17 Aug 2020 08:06:44 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:39582 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728053AbgHQMGn (ORCPT ); Mon, 17 Aug 2020 08:06:43 -0400 Received: by mail-ed1-f65.google.com with SMTP id c10so12056798edk.6; Mon, 17 Aug 2020 05:06:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=POjo4N2UW/F7P1/0nbB8JMCRtfCFZzWav36q5a69RDA=; b=TJhDssrtTcqP+JMBEW0SX+UgrKVExCMcryGzM6IHvFxTksev1ILph/iIwi0YPAZRXg BPO1aydN841WUcp2uDfUsXBT01GLg7UgMVJAY9DAvgfsY+OtYvbA16RMpBk5pGCtzxvx kona72GRcLoGPrvzODmD9TXvQbJU533OT24qiWNzyQfqcHPvPIep1eutjUkjI8616maX 1SNg9/A80y7Cb7fElWOyLRD49MQCO5DXKLpUaxM2/67QBmDsU05HAsO0xp6QX4HLcBmg dKi3M9Ct/oLbDaOrMeSfVMAWmwdzWsEXfpc+zjF7/8PlQ9Eek78hmrbw68Fq3y4uSACg demA== X-Gm-Message-State: AOAM533ytMzR8Mrlmie3zws4G94k4+FjKGi9i5I7iXd9oTaOqvPTCIbf Un/P5ToU3TiYvBROohojgFdnsjc+DycJcg== X-Google-Smtp-Source: ABdhPJymaBf/U0ztL2RTmFCygw0OMokmDearJJKeNRZeMimIQb6zEmgevVCQjBVqVE1yCVN8TRNY2Q== X-Received: by 2002:a05:6402:1e2:: with SMTP id i2mr14330135edy.70.1597666001072; Mon, 17 Aug 2020 05:06:41 -0700 (PDT) Received: from kozik-lap ([194.230.155.242]) by smtp.googlemail.com with ESMTPSA id u6sm14397329ejf.98.2020.08.17.05.06.39 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Aug 2020 05:06:40 -0700 (PDT) Date: Mon, 17 Aug 2020 14:06:38 +0200 From: Krzysztof Kozlowski To: Dan Carpenter Cc: Paul Cercueil , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] memory: jz4780_nemc: Fix an error pointer vs NULL check in probe() Message-ID: <20200817120638.GB2346@kozik-lap> References: <20200803143607.GC346925@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200803143607.GC346925@mwanda> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 03, 2020 at 05:36:07PM +0300, Dan Carpenter wrote: > The devm_ioremap() function returns NULL on error, it doesn't return > error pointers. This bug could lead to an Oops during probe. > > Fixes: f046e4a3f0b9 ("memory: jz4780_nemc: Only request IO memory the driver will use") > Signed-off-by: Dan Carpenter > --- > drivers/memory/jz4780-nemc.c | 4 ++-- Thanks, applied. Best regards, Krzysztof