Re: [PATCH v3] sched/fair: simplfy the work when reweighting entity

peterz
2020-08-18T11:35:44Z

On Tue, Aug 18, 2020 at 11:07:37AM +0200, Vincent Guittot wrote:
> On Tue, 11 Aug 2020 at 13:32, Jiang Biao <benbjiang@gmail.com> wrote:
> >
> > From: Jiang Biao <benbjiang@tencent.com>
> >
> > The code in reweight_entity() can be simplified.
> >
> > For a sched entity on the rq, the entity accounting can be replaced by
> > cfs_rq instantaneous load updates currently called from within the
> > entity accounting.
> >
> > Even though an entity on the rq can't represent a task in
> > reweight_entity() (a task is always dequeued before calling this
> > function) and so the numa task accounting and the rq->cfs_tasks list
> > management of the entity accounting are never called, the redundant
> > cfs_rq->nr_running decrement/increment will be avoided.
> >
> > Signed-off-by: Jiang Biao <benbjiang@tencent.com>
>
> Minor typo of the subject: s/simplfy/simplify/

I've made it "Simplify" :-)

Thanks guys!