From: Crt Mori <cmo@melexis.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Crt Mori <cmo@melexis.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: [PATCH v6 0/5] iio: temperature: mlx90632: Add extended calibration calculations
Date: Tue, 18 Aug 2020 23:37:32 +0200 [thread overview]
Message-ID: <20200818213737.140613-1-cmo@melexis.com> (raw)
Add extended calibration calculations for the new subversion of DSP5.
V6 review comments from Andy Shevchenko <andy.shevchenko@gmail.com:
- Covert all while loops to regmap_read_poll_timeout or
read_poll_timeout even though udelay of more than 20ms is used
in the second. Problem was, that timeout needs to be 800ms,
while polling frequency could be 20ms, but we konw that that
will generate more noise on line than needed. Did some tests and
current number combination seems best. This also caused that
commit messages were adjusted.
V5 review comments from Andy Shevchenko <andy.shevchenko@gmail.com:
- Swap order of patches to avoid re-doing the calculations
- Add fixed name defines for Ambient and Object RAM temperature
channels as per suggestion of the Jonathan Cameron <jic23@kernel.org>
V5:
- Add style changes patch along with current series.
V4 review comments from Andy Shevchenko <andy.shevchenko@gmail.com>:
- Move the function creation for Ta4 to first patch
- Add kernel doc patch for documenting internal struct
- Add patch to convert while loops to do-while loops for
polling
V3 review comments from Andy Shevchenko <andy.shevchenko@gmail.com>:
- Change commit message text to more proper English as per suggestions
- Drop unneeded brackets and parentheses
- Use defines from limits.h
- Remove userspace typedefs as leftovers from porting
- Testing of timeout loops with iopoll.h was no successful,
because delay between measurements is 10ms, but we need to
fill at least 3 channels, so final timeout should be 40ms
which is out of scope of usleep function
- Fixing some typos in comments
V2 review comments from Andy Shevchenko <andy.shevchenko@gmail.com>:
- Convert divison back to shifts to make it more readable
Crt Mori (5):
iio:temperature:mlx90632: Reduce number of equal calulcations
iio:temperature:mlx90632: Add kerneldoc to the internal struct
iio:temperature:mlx90632: Convert polling while loop to regmap
iio:temperature:mlx90632: Adding extended calibration option
iio:temperature:mlx90632: Some stylefixing leftovers
drivers/iio/temperature/mlx90632.c | 274 ++++++++++++++++++++++++++---
1 file changed, 247 insertions(+), 27 deletions(-)
--
2.25.1
next reply other threads:[~2020-08-18 21:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 21:37 Crt Mori [this message]
2020-08-18 21:37 ` [PATCH v6 1/5] iio:temperature:mlx90632: Reduce number of equal calulcations Crt Mori
2020-08-18 21:37 ` [PATCH v6 2/5] iio:temperature:mlx90632: Add kerneldoc to the internal struct Crt Mori
2020-08-18 21:37 ` [PATCH v6 3/5] iio:temperature:mlx90632: Convert polling while loop to regmap Crt Mori
2020-08-19 8:08 ` Andy Shevchenko
2020-08-18 21:37 ` [PATCH v6 4/5] iio:temperature:mlx90632: Adding extended calibration option Crt Mori
2020-08-18 21:37 ` [PATCH v6 5/5] iio:temperature:mlx90632: Some stylefixing leftovers Crt Mori
2020-08-19 8:10 ` Andy Shevchenko
2020-08-29 17:28 ` [PATCH v6 0/5] iio: temperature: mlx90632: Add extended calibration calculations Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818213737.140613-1-cmo@melexis.com \
--to=cmo@melexis.com \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox