public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Ilya Dryomov <idryomov@gmail.com>, Jeff Layton <jlayton@kernel.org>
Cc: Leon Romanovsky <leonro@nvidia.com>,
	ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH] ceph: Delete features that are not used in the kernel
Date: Wed, 19 Aug 2020 10:57:47 +0300	[thread overview]
Message-ID: <20200819075747.917595-1-leon@kernel.org> (raw)

From: Leon Romanovsky <leonro@nvidia.com>

The ceph_features.h has declaration of features that are not in-use
in kernel code. This causes to seeing such compilation warnings in
almost every kernel compilation.

./include/linux/ceph/ceph_features.h:14:24: warning: 'CEPH_FEATURE_UID' defined but not used [-Wunused-const-variable=]
   14 |  static const uint64_t CEPH_FEATURE_##name = (1ULL<<bit);  \
      |                        ^~~~~~~~~~~~~
./include/linux/ceph/ceph_features.h:75:1: note: in expansion of macro 'DEFINE_CEPH_FEATURE'
   75 | DEFINE_CEPH_FEATURE( 0, 1, UID)
      | ^~~~~~~~~~~~~~~~~~~

The upstream kernel indeed doesn't have any use of them, so delete it.

Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
I'm sending this as RFC because probably the patch is wrong, but I
would like to bring your attention to the existing problem and asking
for an acceptable solution.
---
 include/linux/ceph/ceph_features.h | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/include/linux/ceph/ceph_features.h b/include/linux/ceph/ceph_features.h
index fcd84e8d88f4..922e74c84c76 100644
--- a/include/linux/ceph/ceph_features.h
+++ b/include/linux/ceph/ceph_features.h
@@ -72,13 +72,9 @@
  * the bit ever speak to each other.
  */

-DEFINE_CEPH_FEATURE( 0, 1, UID)
-DEFINE_CEPH_FEATURE( 1, 1, NOSRCADDR)
 DEFINE_CEPH_FEATURE_RETIRED( 2, 1, MONCLOCKCHECK, JEWEL, LUMINOUS)

-DEFINE_CEPH_FEATURE( 3, 1, FLOCK)
 DEFINE_CEPH_FEATURE( 4, 1, SUBSCRIBE2)
-DEFINE_CEPH_FEATURE( 5, 1, MONNAMES)
 DEFINE_CEPH_FEATURE( 6, 1, RECONNECT_SEQ)
 DEFINE_CEPH_FEATURE( 7, 1, DIRLAYOUTHASH)
 DEFINE_CEPH_FEATURE( 8, 1, OBJECTLOCATOR)
@@ -176,10 +172,7 @@ DEFINE_CEPH_FEATURE_DEPRECATED(63, 1, RESERVED_BROKEN, LUMINOUS) // client-facin
  * Features supported.
  */
 #define CEPH_FEATURES_SUPPORTED_DEFAULT		\
-	(CEPH_FEATURE_NOSRCADDR |		\
-	 CEPH_FEATURE_FLOCK |			\
-	 CEPH_FEATURE_SUBSCRIBE2 |		\
-	 CEPH_FEATURE_RECONNECT_SEQ |		\
+	(CEPH_FEATURE_RECONNECT_SEQ |		\
 	 CEPH_FEATURE_DIRLAYOUTHASH |		\
 	 CEPH_FEATURE_PGID64 |			\
 	 CEPH_FEATURE_PGPOOL3 |			\
--
2.26.2


             reply	other threads:[~2020-08-19  7:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19  7:57 Leon Romanovsky [this message]
2020-08-19  8:47 ` [RFC PATCH] ceph: Delete features that are not used in the kernel Ilya Dryomov
2020-08-19  9:40   ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200819075747.917595-1-leon@kernel.org \
    --to=leon@kernel.org \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=jlayton@kernel.org \
    --cc=leonro@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox