From: Borislav Petkov <bp@alien8.de>
To: Chris Down <chris@chrisdown.name>
Cc: linux-kernel@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
kernel-team@fb.com, sean.j.christopherson@intel.com,
tony.luck@intel.com, torvalds@linux-foundation.org,
x86@kernel.org
Subject: Re: [PATCH 2/2] x86: Make source of unrecognised MSR writes unambiguous
Date: Wed, 19 Aug 2020 16:51:58 +0200 [thread overview]
Message-ID: <20200819145158.GC19351@zn.tnic> (raw)
In-Reply-To: <df42b70ed20d616d7c2d7f42cd38300115584619.1597677395.git.chris@chrisdown.name>
On Mon, Aug 17, 2020 at 04:24:36PM +0100, Chris Down wrote:
> In many cases the comm enough isn't enough to distinguish the offender,
> since for interpreted languages it's likely just going to be "python3"
> or whatever. Add the pid to make it unambiguous.
>
> Signed-off-by: Chris Down <chris@chrisdown.name>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Jakub Kicinski <kuba@kernel.org>
> ---
> arch/x86/kernel/msr.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c
> index 3babb0e58b0e..76b6b0011d62 100644
> --- a/arch/x86/kernel/msr.c
> +++ b/arch/x86/kernel/msr.c
> @@ -99,8 +99,9 @@ static int filter_write(u32 reg)
> if (!__ratelimit(&fw_rs) || reg == MSR_IA32_ENERGY_PERF_BIAS)
> return 0;
>
> - pr_err("Write to unrecognized MSR 0x%x by %s\n"
> - "Please report to x86@kernel.org\n", reg, current->comm);
> + pr_err("Write to unrecognized MSR 0x%x by pid %s:%d\n"
Perhaps make that "... by %s (pid: %d)\n".
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2020-08-19 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 15:24 [PATCH 0/2] a couple of userspace MSR filtering improvements Chris Down
2020-08-17 15:24 ` [PATCH 1/2] x86: Prevent userspace MSR access from dominating the console Chris Down
2020-08-19 14:50 ` Borislav Petkov
2020-08-17 15:24 ` [PATCH 2/2] x86: Make source of unrecognised MSR writes unambiguous Chris Down
2020-08-19 14:51 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819145158.GC19351@zn.tnic \
--to=bp@alien8.de \
--cc=akpm@linux-foundation.org \
--cc=chris@chrisdown.name \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sean.j.christopherson@intel.com \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).