From: Christoph Hellwig <hch@lst.de>
To: David Fugate <david.fugate@linux.intel.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>,
Kanchan Joshi <joshi.k@samsung.com>,
"Damien.LeMoal@wdc.com" <Damien.LeMoal@wdc.com>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"johannes.thumshirn@wdc.com" <johannes.thumshirn@wdc.com>,
Nitesh Shetty <nj.shetty@samsung.com>,
SelvaKumar S <selvakuma.s1@samsung.com>,
Javier Gonzalez <javier.gonz@samsung.com>,
david.fugate@intel.com
Subject: Re: [PATCH 2/2] nvme: add emulation for zone-append
Date: Thu, 20 Aug 2020 07:51:54 +0200 [thread overview]
Message-ID: <20200820055154.GA5758@lst.de> (raw)
In-Reply-To: <d9cc3ece0c70b51c2d40998081375ad3fa39ece2.camel@linux.intel.com>
On Wed, Aug 19, 2020 at 05:43:29PM -0600, David Fugate wrote:
> There were queries? My key takeaways were a maintainer NAK followed by
> instructions to make the Intel drive align with the driver by
> implementing NOIOB. While I disagree with the rejection as it appeared
> to be based entirely on politics, I can accept it as the quirk wasn't
> in the spec.
Stop the crap now please. I'm really offended. I'm offended by you
implying that I pay corporate poitics. I'm primary a Linux developer,
and I stand for what I think is good for Linux. I fight inside companies
that pay me what is good for Linux, I work hard with companies that do not
pay to convinve them what is right. I waste a lot of precious time to sit
in standards meetings to do what is right for Linux. And now you come
here with the politics arguments. Stop, it please.
The Intel NOIOB quirk was in the driver since day 1, added by Matthew
probably with no bad intent, but we kept growing the lists and finally
got Intel to standardized because it was good for Linux, and to be
honest good for Intel as updating quirks in half a dozen drivers
simply does not scale. We got a really nice trivial TP out of it. But
we really should not see any new drivers that do not implement one damn
trivial field a long time after the TP has been publushed. That is not
politics.
Making a fuzz and playing the corporate card on a Linux mailing list
is politics, really bad politics and you need to stop it.
> It's not fair to make this same "your drive should align with the
> driver" demand of Samsung because we *are* talking about a spec'ed
> feature here.
Huh. Next time Dell or NetApp or Facebook are going to require an
optional NVMe feature, and OCP feature or even a vendor specific
feature you are going to go to them and say "you don't play fair"?
> Technical critques of their patches and real performance
> degrades observed are fair game and objective; "your company did
> the nastiest possible move violating the normal NVMe procedures to make
> it optional" is not.
It is pretty fair game if you know the background, that is that I spent
countless hours to make this feature fit the Linux I/O stack requirement
perfecty and worked that it is there. We might as well rely on it.
next prev parent reply other threads:[~2020-08-20 5:52 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200818053247epcas5p262c5fd7e207dfa5145011c4329cf239d@epcas5p2.samsung.com>
2020-08-18 5:29 ` [PATCH 0/2] enable append-emulation for ZNS Kanchan Joshi
2020-08-18 5:29 ` [PATCH 1/2] nvme: set io-scheduler requirement " Kanchan Joshi
2020-08-18 7:11 ` Christoph Hellwig
2020-08-19 9:26 ` Kanchan Joshi
2020-08-19 9:38 ` Damien Le Moal
2020-08-19 10:31 ` Kanchan Joshi
2020-08-19 11:17 ` Damien Le Moal
2020-09-07 7:00 ` Kanchan Joshi
2020-09-07 8:22 ` Damien Le Moal
2020-09-07 11:23 ` Kanchan Joshi
2020-09-07 11:37 ` Damien Le Moal
2020-09-07 11:54 ` Kanchan Joshi
2020-09-07 12:53 ` Damien Le Moal
2020-08-18 5:29 ` [PATCH 2/2] nvme: add emulation for zone-append Kanchan Joshi
2020-08-18 7:12 ` Christoph Hellwig
2020-08-18 9:50 ` Javier Gonzalez
2020-08-18 10:51 ` Matias Bjørling
2020-08-18 18:11 ` Javier Gonzalez
2020-08-18 15:50 ` Christoph Hellwig
2020-08-18 18:04 ` Javier Gonzalez
2020-08-19 7:40 ` Christoph Hellwig
2020-08-19 8:33 ` Javier Gonzalez
2020-08-19 9:14 ` Damien Le Moal
2020-08-19 10:43 ` Christoph Hellwig
2020-08-20 6:45 ` Javier Gonzalez
2020-08-19 10:49 ` Christoph Hellwig
2020-08-18 16:58 ` Keith Busch
2020-08-18 17:29 ` Javier Gonzalez
2020-08-18 17:39 ` Keith Busch
2020-08-18 18:13 ` Javier Gonzalez
2020-08-19 19:11 ` David Fugate
2020-08-19 19:25 ` Jens Axboe
2020-08-19 21:54 ` David Fugate
2020-08-19 22:10 ` Keith Busch
2020-08-19 23:43 ` David Fugate
2020-08-20 3:45 ` Keith Busch
2020-08-20 23:26 ` David Fugate
2020-08-20 5:51 ` Christoph Hellwig [this message]
2020-08-20 6:37 ` Javier Gonzalez
2020-08-20 6:52 ` Christoph Hellwig
2020-08-20 8:03 ` Javier Gonzalez
2020-08-19 21:42 ` Keith Busch
2020-08-20 7:37 ` Kanchan Joshi
2020-08-20 8:14 ` Javier Gonzalez
2020-08-20 5:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820055154.GA5758@lst.de \
--to=hch@lst.de \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=david.fugate@intel.com \
--cc=david.fugate@linux.intel.com \
--cc=javier.gonz@samsung.com \
--cc=johannes.thumshirn@wdc.com \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nj.shetty@samsung.com \
--cc=sagi@grimberg.me \
--cc=selvakuma.s1@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).