From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E8CBC433E1 for ; Thu, 20 Aug 2020 06:20:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 823FE20758 for ; Thu, 20 Aug 2020 06:20:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726749AbgHTGU3 (ORCPT ); Thu, 20 Aug 2020 02:20:29 -0400 Received: from verein.lst.de ([213.95.11.211]:40836 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725778AbgHTGU1 (ORCPT ); Thu, 20 Aug 2020 02:20:27 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 378DF68BEB; Thu, 20 Aug 2020 08:20:25 +0200 (CEST) Date: Thu, 20 Aug 2020 08:20:24 +0200 From: Christoph Hellwig To: Linus Torvalds Cc: Peter Zijlstra , Christoph Hellwig , Ingo Molnar , Linux Kernel Mailing List , Will Deacon , "Paul E. McKenney" , Jens Axboe , Chris Wilson , David Miller , Jakub Kicinski , =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , Oleg Nesterov , Vincent Guittot Subject: Re: [RFC][PATCH v2 08/10] smp,irq_work: Use the new irq_work API Message-ID: <20200820062024.GB6447@lst.de> References: <20200818105102.926463950@infradead.org> <20200818112418.460474861@infradead.org> <20200818162542.GB27196@lst.de> <20200819072209.GU2674@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 19, 2020 at 11:50:55AM -0700, Linus Torvalds wrote: > On Wed, Aug 19, 2020 at 12:22 AM wrote: > > > > That is, the external serialization comes from the non-atomic > > test-and-set they both have. This works nicely when there is external > > state that already serializes things, but totally comes apart (and > > causes trivial list corruption) when you get it wrong. > > Quite often, there just isn't any *need* for serialization, because > there is only ever one op active. Yes, that's pretty much the block use case. The request gets completed once, and and the IPI is used to bounce it back to the issuing cpu.