From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39706C433E1 for ; Thu, 20 Aug 2020 10:10:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B5792067C for ; Thu, 20 Aug 2020 10:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597918239; bh=5dw8O6/efM/TLjDZygFFroeoWP40Tc0rI4PqYfwm+pw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=FDKx9UaTThuyFZ/GOFk0aB3SOdUT7AYLKWVLPUAy7r7yEq5rfchY0OMKT76LUbBk0 RCVGfPf2d690W0Fw5JHbRGTgORIyWnyGiU9Tu/5hUDbyAwJBdaK2x4LUOFGsDCJ1LS oZiqeiOz7sj45Yq25ZntHL3nBgAtxBU5dAXq2zNQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730664AbgHTKKi (ORCPT ); Thu, 20 Aug 2020 06:10:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:47186 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728496AbgHTKKa (ORCPT ); Thu, 20 Aug 2020 06:10:30 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 660FF20724; Thu, 20 Aug 2020 10:10:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597918230; bh=5dw8O6/efM/TLjDZygFFroeoWP40Tc0rI4PqYfwm+pw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0MVh8gB8i26X3bmbIj2ipFAy9VGBlqxF5VIrRmb997D7Ok3MQ4kSrjnYMsVk238CB TvjuO2PHD2SrQUTvTmr2/G4DAGb6kIY6W8M6wJ1h4ZFBVDHSuBoKU0SDlH8MmrOcdT iBeQy87Jn5S/ZE8kxP7m742B5q2wujqowssgviZ4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chuhong Yuan , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.14 098/228] media: exynos4-is: Add missed check for pinctrl_lookup_state() Date: Thu, 20 Aug 2020 11:21:13 +0200 Message-Id: <20200820091612.520058933@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200820091607.532711107@linuxfoundation.org> References: <20200820091607.532711107@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan [ Upstream commit 18ffec750578f7447c288647d7282c7d12b1d969 ] fimc_md_get_pinctrl() misses a check for pinctrl_lookup_state(). Add the missed check to fix it. Fixes: 4163851f7b99 ("[media] s5p-fimc: Use pinctrl API for camera ports configuration]") Signed-off-by: Chuhong Yuan Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/exynos4-is/media-dev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c index b2eb830c0360a..f772c9b92d9ba 100644 --- a/drivers/media/platform/exynos4-is/media-dev.c +++ b/drivers/media/platform/exynos4-is/media-dev.c @@ -1258,6 +1258,9 @@ static int fimc_md_get_pinctrl(struct fimc_md *fmd) pctl->state_idle = pinctrl_lookup_state(pctl->pinctrl, PINCTRL_STATE_IDLE); + if (IS_ERR(pctl->state_idle)) + return PTR_ERR(pctl->state_idle); + return 0; } -- 2.25.1