Re: [PATCH 5/7] spi: fsi: Implement restricted size for certain controllers

Mark Brown
2020-08-20T17:19:41Z

[-- Attachment #1: Type: text/plain, Size: 694 bytes --]

On Thu, Aug 20, 2020 at 12:02:26PM -0500, Eddie James wrote:
> Some of the FSI-attached SPI controllers cannot use the loop command in
> programming the sequencer due to security requirements. Add a boolean
> devicetree property that describes this condition and restrict the
> size for these controllers. Also, add more transfers directly in the
> sequence up to the length of the sequence register.

If there is one difference between implementations of the controller
there are likely to be more - why have a property here rather than use
compatible strings for the different hardware variants? Compatible
strings mean that as more differences are discovered existing DTs
continue to work.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]