From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B945C433DF for ; Thu, 20 Aug 2020 18:53:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3EFEE207DE for ; Thu, 20 Aug 2020 18:53:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597949580; bh=rSUz5YSmWP/BtGBq8Tyabp7GiDHOHBwKBlQJLdfm/nQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=w7miQWiKtaKBQXIA1Etd0ccOk4DCf1hk+RhSAMMNwQJ4Mb0gpLjCxyKmtifY9XTTs io8jxGQF3mi8O4Wu2EVMyEqSld0/BJXlLhsR1193IalYftwjgFoWtyWexYZ7KXHmk8 FtIilJUN+PsWFoQIyqn5SZLxBtvD58NmNReLbiMo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728005AbgHTSwx (ORCPT ); Thu, 20 Aug 2020 14:52:53 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:40950 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728035AbgHTSwp (ORCPT ); Thu, 20 Aug 2020 14:52:45 -0400 Received: by mail-wr1-f68.google.com with SMTP id l2so3137212wrc.7 for ; Thu, 20 Aug 2020 11:52:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BJ095o2R3pfLHrGrBkg75D4r4m29RUPbdiOfPVS83Ok=; b=q7QgR74Ox6vR+DfxgQTlpAUjOAHdFQ/d5J3xL9N4RmSLZxD3OOYIjGZoGNxPaxjmDv whahzFOBXE0MfhQtKDlV5pqf6dvw2j5BhJtZIh1BArDbxll5emGL1GKX3zsAumfH1zj/ 67WA7YrhVYRF6jVl/WK9HkgF2bew+VzPAT0cKWm5ykdxfEZ9nUCxBcM9+6jrAfw0emkM AtkyyACw3SqUAKGstklDzQOfsEMlML/38HNV2jr3GQpi0KugDXprESU/h1O8R7fIF/JP ljULnJ1a11jICOs1F3yM6gTtwkuI1WWnOil82G/vHBE9F4TFFqqS+7YlYRpSXUOZU8cq KFEw== X-Gm-Message-State: AOAM532OOF4Eizvv+dFgeuIgzd1LQwmaLM7vUwFxgOxAXKKprsBOPpzL vH9UxAn29YMrMFiRZe31D+I= X-Google-Smtp-Source: ABdhPJzkDPZAouwqIHWPOQHYosJiqPAJhKrgroO2UbF2yZfw92R8S8xfuBRKKq1Q9umYszmavSEPPw== X-Received: by 2002:a5d:49c9:: with SMTP id t9mr111645wrs.302.1597949563855; Thu, 20 Aug 2020 11:52:43 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id m20sm22707438wmc.1.2020.08.20.11.52.42 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Aug 2020 11:52:43 -0700 (PDT) Date: Thu, 20 Aug 2020 20:52:41 +0200 From: Krzysztof Kozlowski To: Alex Dewar Cc: Markus Mayer , bcm-kernel-feedback-list@broadcom.com, Florian Fainelli , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] memory: brcmstb_dpfe: Fix memory leak Message-ID: <20200820185241.GA2833@kozik-lap> References: <20200820172118.781324-1-alex.dewar90@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200820172118.781324-1-alex.dewar90@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 20, 2020 at 06:21:18PM +0100, Alex Dewar wrote: > In brcmstb_dpfe_download_firmware(), memory is allocated to variable fw by > firmware_request_nowarn(), but never released. Fix up to release fw on > all return paths. > > Signed-off-by: Alex Dewar > --- > v2: Don't assign ret unnecessarily (Krzysztof) > --- > drivers/memory/brcmstb_dpfe.c | 16 ++++++++++------ Thanks, applied with acks, CC stable and Fixes tag. Best regards, Krzysztof