Re: [PATCH 14/17] file: Merge __fd_install into fd_install

Christian Brauner
2020-08-18T10:15:49Z

On Mon, Aug 17, 2020 at 05:04:22PM -0500, Eric W. Biederman wrote:
> The function __fd_install was added to support binder[1]. With binder
> fixed[2] there are no more users. Further with get_files_struct
> removed there can be no more users of __fd_install that pass anything
> except current->files.
>
> As fd_install just calls __fd_install with "files=current->files",
> merge them together by transforming the files parameter into a
> local variable initialized to current->files.
>
> [1] f869e8a7f753 ("expose a low-level variant of fd_install() for binder")
> [2] 44d8047f1d87 ("binder: use standard functions to allocate fds")
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
> ---

+1 on __fd_install() going away.
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>