public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Azhar Shaikh <azhar.shaikh@intel.com>
To: bleung@chromium.org, enric.balletbo@collabora.com,
	groeck@chromium.org, heikki.krogerus@linux.intel.com,
	pmalani@chromium.org
Cc: linux-kernel@vger.kernel.org, azhar.shaikh@intel.com,
	rajmohan.mani@intel.com, utkarsh.h.patel@intel.com,
	casey.g.bowman@intel.com
Subject: [PATCH v4 1/3] platform/chrome: cros_ec_typec: Send enum values to usb_role_switch_set_role()
Date: Thu, 20 Aug 2020 16:38:30 -0700	[thread overview]
Message-ID: <20200820233833.4551-2-azhar.shaikh@intel.com> (raw)
In-Reply-To: <20200820233833.4551-1-azhar.shaikh@intel.com>

usb_role_switch_set_role() has the second argument as enum for usb_role.
Currently depending upon the data role i.e. UFP(0) or DFP(1) is sent.
This eventually translates to USB_ROLE_NONE in case of UFP and
USB_ROLE_DEVICE in case of DFP. Correct this by sending correct enum
values as USB_ROLE_DEVICE in case of UFP and USB_ROLE_HOST in case of
DFP.

Fixes: 7e7def15fa4b ("platform/chrome: cros_ec_typec: Add USB mux control")
Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
Cc: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
Changes in v4:
 - Remove extra line between Fixes and Signed-off tag.
 - Added Reviewed-by and Cc tags from v1 and v2.

Changes in v3:
 - No changes

Changes in v2:
 - Update the commit message to change 'USB_ROLE_HOST in case of
    UFP.'  to 'USB_ROLE_HOST in case of DFP.'

 drivers/platform/chrome/cros_ec_typec.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index 3fcd27ec9ad8..06108212ee94 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -591,7 +591,8 @@ static int cros_typec_port_update(struct cros_typec_data *typec, int port_num)
 		dev_warn(typec->dev, "Configure muxes failed, err = %d\n", ret);
 
 	return usb_role_switch_set_role(typec->ports[port_num]->role_sw,
-					!!(resp.role & PD_CTRL_RESP_ROLE_DATA));
+				       resp.role & PD_CTRL_RESP_ROLE_DATA
+				       ? USB_ROLE_HOST : USB_ROLE_DEVICE);
 }
 
 static int cros_typec_get_cmd_version(struct cros_typec_data *typec)
-- 
2.17.1


  reply	other threads:[~2020-08-20 23:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20 23:38 [PATCH v4 0/3] TypeC Connector Class driver improvements Azhar Shaikh
2020-08-20 23:38 ` Azhar Shaikh [this message]
2020-08-20 23:38 ` [PATCH v4 2/3] platform/chrome: cros_ec_typec: Avoid setting usb role twice during disconnect Azhar Shaikh
2020-08-20 23:38 ` [PATCH v4 3/3] platform/chrome: cros_ec_typec: Re-order connector configuration steps Azhar Shaikh
2020-08-21  0:01   ` Prashant Malani
2020-08-21  7:13 ` [PATCH v4 0/3] TypeC Connector Class driver improvements Enric Balletbo i Serra
2020-08-21 13:34   ` Shaikh, Azhar
2020-08-21 13:36     ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200820233833.4551-2-azhar.shaikh@intel.com \
    --to=azhar.shaikh@intel.com \
    --cc=bleung@chromium.org \
    --cc=casey.g.bowman@intel.com \
    --cc=enric.balletbo@collabora.com \
    --cc=groeck@chromium.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmalani@chromium.org \
    --cc=rajmohan.mani@intel.com \
    --cc=utkarsh.h.patel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox