From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A1DEC433E1 for ; Fri, 21 Aug 2020 13:39:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 469C82075E for ; Fri, 21 Aug 2020 13:39:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="LZdFmWso" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728508AbgHUNjf (ORCPT ); Fri, 21 Aug 2020 09:39:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727870AbgHUNjW (ORCPT ); Fri, 21 Aug 2020 09:39:22 -0400 Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54CABC061573 for ; Fri, 21 Aug 2020 06:39:22 -0700 (PDT) Received: by mail-qt1-x841.google.com with SMTP id v22so1178922qtq.8 for ; Fri, 21 Aug 2020 06:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=MKVtu0huNWPoi4f70gbVdXgIVo7OPlWGvtT3lWq7dGQ=; b=LZdFmWso+59T6z6TbPDyyIWFyw3bTNLc9rC1+8nvs+MVu7jE/q4ePc9TCedeJNpKQY SHy8y7MCk6QEYVD94wZD54TGaMiKSpWh5ADHL7W+OUkwt5Fyy0mNF+NblXEH8/RsUonU HzpX7jNNQIw0SMgqvqBP4ghbSIFp0xKqob8PZx/JxAKtgmYmg+LS25DctYAeBv1N3nMX ztETxYJDU1/Qr4H4/3sluSXyEDmnWwoPofRAXC6iXMip0xTexksS0ne0WXzmlYJUMMBS 16unnnh0g/mOEyndZteVQ8HZyC8qi2OCQmIpfehfh/q9FwdauqIl2Vh7FRWyepTzjUOD rr7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=MKVtu0huNWPoi4f70gbVdXgIVo7OPlWGvtT3lWq7dGQ=; b=dbARz8I9BIgq7Uod7wAI9huJER5teWm11CkM2rM3RLzWJ4bqID6pEElk0xgPS9mxhg TKT7+YEUEWdcXlvsK1WDnTz8n4jCEe1JjhTVFnM/R/ChMUyyqQsDbkYAPLICDFRflOs6 nPV9S+ISsv+54qg3Hy9Ghv2Ey+DAogLR7iFnRTq8N7RTwk/BPPttzGIozlRp7mF/k46F sPqbJxDnFfaNfNgYASEDyBCxKIDmnOFw0t5WPw4GP853SSYFpy13163h9c8yRDgbbafd zXwQN5g9n9y0Wm74aucZe8B/7OO+SBm2fbD6WMCsNP9pwpBC5gRIJ1TyjoZikLpAkHkb BJmA== X-Gm-Message-State: AOAM532L0jcjFSaNizXByZmjUisWSIZGCqz92YGjWNijefsPDr7rzgZS tZsj0xI3AuLDdZUoXh+oa03PIw== X-Google-Smtp-Source: ABdhPJwd8K69wIrq2mgwwLZ8AViAeiNGiIdzV7q9GmbkmU8PGNUTNimUttg8vFRBThqS0YVzDAjtgw== X-Received: by 2002:ac8:6a07:: with SMTP id t7mr2673949qtr.1.1598017161575; Fri, 21 Aug 2020 06:39:21 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id g129sm1812567qkb.39.2020.08.21.06.39.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2020 06:39:20 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1k97GJ-00B03c-28; Fri, 21 Aug 2020 10:39:19 -0300 Date: Fri, 21 Aug 2020 10:39:19 -0300 From: Jason Gunthorpe To: =?utf-8?B?SMOla29u?= Bugge Cc: Dinghao Liu , kjlu@umn.edu, Doug Ledford , Yishai Hadas , Leon Romanovsky , Michel Lespinasse , Ariel Elior , Michal Kalderon , OFED mailing list , linux-kernel@vger.kernel.org Subject: Re: [PATCH] IB/uverbs: Fix memleak in ib_uverbs_add_one Message-ID: <20200821133919.GC24045@ziepe.ca> References: <20200821081013.4762-1-dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 21, 2020 at 11:47:32AM +0200, Håkon Bugge wrote: > > > > On 21 Aug 2020, at 10:10, Dinghao Liu wrote: > > > > When ida_alloc_max() fails, uverbs_dev should be freed > > just like when init_srcu_struct() fails. It's the same > > for the error paths after this call. > > > > Signed-off-by: Dinghao Liu > > drivers/infiniband/core/uverbs_main.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/infiniband/core/uverbs_main.c b/drivers/infiniband/core/uverbs_main.c > > index 37794d88b1f3..c6b4e3e2aff6 100644 > > +++ b/drivers/infiniband/core/uverbs_main.c > > @@ -1170,6 +1170,7 @@ static int ib_uverbs_add_one(struct ib_device *device) > > ib_uverbs_comp_dev(uverbs_dev); > > wait_for_completion(&uverbs_dev->comp); > > put_device(&uverbs_dev->dev); > > + kfree(uverbs_dev); > > Isn't this taken care of by the *release* function pointer, which > happens to be ib_uverbs_release_dev() ? Yep Jason