From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7613C433E1 for ; Fri, 21 Aug 2020 16:47:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 93452206DA for ; Fri, 21 Aug 2020 16:47:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598028463; bh=m/lZTTCYIlktsXBJf/jLMe17+s6jA/ctQNbMskeBEqg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=k1EMCdQ4SiE/27uyBUdsc+z7zsL1XD22Hi+STABWVVzFzaePOscWEKQEnBA4FfgRT IQU9QGEVhgBUQWm5Hwa7Bz7NQ15IS1+IJLfr5pIHiuOtxLDWryNQ/EmsFHrWGB49c9 8RdBZfE4JB2NYxxQ3kIYpiP0tqwMvlvfv+kzzk+U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728543AbgHUQrc (ORCPT ); Fri, 21 Aug 2020 12:47:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:49910 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728373AbgHUQU3 (ORCPT ); Fri, 21 Aug 2020 12:20:29 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1E9D422CA0; Fri, 21 Aug 2020 16:19:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598026773; bh=m/lZTTCYIlktsXBJf/jLMe17+s6jA/ctQNbMskeBEqg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pnhgau6hD0DDlPWCh2Y6SJ++IV3fU8mDEvYlkeUaxbvqRXXoaPYMs+dAdBO1rdRPq wPB1Q5CopxiFV8KNYkp1c/TE0hndoXFxfKv3J7WCLpn8+0KYS0TvXsCmS+FqHs4yZb p9xRFtsja3J9LXzQoSt2HNmYOa7fJIQ3qSx2RusY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jing Xiangfeng , Mike Christie , "Martin K . Petersen" , Sasha Levin , open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 27/30] scsi: iscsi: Do not put host in iscsi_set_flashnode_param() Date: Fri, 21 Aug 2020 12:18:54 -0400 Message-Id: <20200821161857.348955-27-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200821161857.348955-1-sashal@kernel.org> References: <20200821161857.348955-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jing Xiangfeng [ Upstream commit 68e12e5f61354eb42cfffbc20a693153fc39738e ] If scsi_host_lookup() fails we will jump to put_host which may cause a panic. Jump to exit_set_fnode instead. Link: https://lore.kernel.org/r/20200615081226.183068-1-jingxiangfeng@huawei.com Reviewed-by: Mike Christie Signed-off-by: Jing Xiangfeng Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/scsi_transport_iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c index 9589015234693..c3170500a1a1d 100644 --- a/drivers/scsi/scsi_transport_iscsi.c +++ b/drivers/scsi/scsi_transport_iscsi.c @@ -3172,7 +3172,7 @@ static int iscsi_set_flashnode_param(struct iscsi_transport *transport, pr_err("%s could not find host no %u\n", __func__, ev->u.set_flashnode.host_no); err = -ENODEV; - goto put_host; + goto exit_set_fnode; } idx = ev->u.set_flashnode.flashnode_idx; -- 2.25.1