From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F5ECC433E1 for ; Fri, 21 Aug 2020 16:36:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5DE1220738 for ; Fri, 21 Aug 2020 16:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598027782; bh=7yiB7gFwFY9Oupeh3xRREVD3VP30GK9Ry7XDQ1lZtow=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=KGGQVzE3oT4y849vfGiAIzrD00vvO44XvZGvs0mL8dSCOHtSpBXQvmBYBbrkBQb64 EGHIP/D5g6R2cj80XMKOO6ctniWiyVZeGa10wpwC91GMfui4hZ4VaTrsbH5PClNLDm NV9LKBzdErBIo2vTmKFfSehUYHOHi55xJHzQBHKo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728300AbgHUQgU (ORCPT ); Fri, 21 Aug 2020 12:36:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:50912 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728428AbgHUQVO (ORCPT ); Fri, 21 Aug 2020 12:21:14 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 509B222D2A; Fri, 21 Aug 2020 16:20:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598026824; bh=7yiB7gFwFY9Oupeh3xRREVD3VP30GK9Ry7XDQ1lZtow=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nftwPg6clo1IilvuGf2AsqH1w7ycxx4ERrtjnxPvgiKTHpnAV9m8uYj7SrEfaWKAu 9Te6yi1ljw5zytEAu3oPQGX0YubkleuuCVNHSpbVJtnmzUR507rIAV/3fjK9xGZUqc 7i7aR0wFMWg0/JvsmeeuPRFKRiqJrL6L4LnNrhjY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Navid Emamdoost , Alex Deucher , Sasha Levin , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 4.4 07/22] drm/amdgpu: fix ref count leak in amdgpu_driver_open_kms Date: Fri, 21 Aug 2020 12:19:59 -0400 Message-Id: <20200821162014.349506-7-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200821162014.349506-1-sashal@kernel.org> References: <20200821162014.349506-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Navid Emamdoost [ Upstream commit 9ba8923cbbe11564dd1bf9f3602add9a9cfbb5c6 ] in amdgpu_driver_open_kms the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c index e35e603710b4d..356726a5d739a 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c @@ -521,7 +521,7 @@ int amdgpu_driver_open_kms(struct drm_device *dev, struct drm_file *file_priv) r = pm_runtime_get_sync(dev->dev); if (r < 0) - return r; + goto pm_put; fpriv = kzalloc(sizeof(*fpriv), GFP_KERNEL); if (unlikely(!fpriv)) @@ -539,6 +539,7 @@ int amdgpu_driver_open_kms(struct drm_device *dev, struct drm_file *file_priv) file_priv->driver_priv = fpriv; pm_runtime_mark_last_busy(dev->dev); +pm_put: pm_runtime_put_autosuspend(dev->dev); return 0; -- 2.25.1