* [PATCH v3] docs: trusted-encrypted.rst: update parameters for command examples
@ 2020-08-18 17:00 Coly Li
2020-08-19 21:02 ` Jarkko Sakkinen
0 siblings, 1 reply; 6+ messages in thread
From: Coly Li @ 2020-08-18 17:00 UTC (permalink / raw)
To: keyrings, linux-kernel
Cc: Coly Li, Dan Williams, James Bottomley, Jarkko Sakkinen,
Mimi Zohar, Stefan Berger
The parameters in command examples for tpm2_createprimary and
tpm2_evictcontrol are outdated, people (like me) are not able to create
trusted key by these command examples.
This patch updates the parameters of command example tpm2_createprimary
and tpm2_evictcontrol in trusted-encrypted.rst. With Linux kernel v5.8
and tpm2-tools-4.1, people can create a trusted key by following the
examples in this document.
Signed-off-by: Coly Li <colyli@suse.de>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: James Bottomley <jejb@linux.ibm.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Mimi Zohar <zohar@linux.ibm.com>
Cc: Stefan Berger <stefanb@linux.ibm.com>
---
Changelog:
v3: update commit log with review comments from Jarkko Sakkinen.
v2: remove the change of trusted key related operation.
v1: initial version.
Documentation/security/keys/trusted-encrypted.rst | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/Documentation/security/keys/trusted-encrypted.rst b/Documentation/security/keys/trusted-encrypted.rst
index 9483a7425ad5..1da879a68640 100644
--- a/Documentation/security/keys/trusted-encrypted.rst
+++ b/Documentation/security/keys/trusted-encrypted.rst
@@ -39,10 +39,9 @@ With the IBM TSS 2 stack::
Or with the Intel TSS 2 stack::
- #> tpm2_createprimary --hierarchy o -G rsa2048 -o key.ctxt
+ #> tpm2_createprimary --hierarchy o -G rsa2048 -c key.ctxt
[...]
- handle: 0x800000FF
- #> tpm2_evictcontrol -c key.ctxt -p 0x81000001
+ #> tpm2_evictcontrol -c key.ctxt 0x81000001
persistentHandle: 0x81000001
Usage::
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3] docs: trusted-encrypted.rst: update parameters for command examples
2020-08-18 17:00 [PATCH v3] docs: trusted-encrypted.rst: update parameters for command examples Coly Li
@ 2020-08-19 21:02 ` Jarkko Sakkinen
2020-08-19 21:04 ` Jarkko Sakkinen
2020-08-19 23:03 ` Stefan Berger
0 siblings, 2 replies; 6+ messages in thread
From: Jarkko Sakkinen @ 2020-08-19 21:02 UTC (permalink / raw)
To: Coly Li
Cc: keyrings, linux-kernel, Dan Williams, James Bottomley, Mimi Zohar,
Stefan Berger
On Wed, Aug 19, 2020 at 01:00:02AM +0800, Coly Li wrote:
> The parameters in command examples for tpm2_createprimary and
> tpm2_evictcontrol are outdated, people (like me) are not able to create
> trusted key by these command examples.
>
> This patch updates the parameters of command example tpm2_createprimary
> and tpm2_evictcontrol in trusted-encrypted.rst. With Linux kernel v5.8
> and tpm2-tools-4.1, people can create a trusted key by following the
> examples in this document.
>
> Signed-off-by: Coly Li <colyli@suse.de>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Cc: Mimi Zohar <zohar@linux.ibm.com>
> Cc: Stefan Berger <stefanb@linux.ibm.com>
OK, now it is clear. Thank you.
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
> ---
> Changelog:
> v3: update commit log with review comments from Jarkko Sakkinen.
> v2: remove the change of trusted key related operation.
> v1: initial version.
>
> Documentation/security/keys/trusted-encrypted.rst | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/security/keys/trusted-encrypted.rst b/Documentation/security/keys/trusted-encrypted.rst
> index 9483a7425ad5..1da879a68640 100644
> --- a/Documentation/security/keys/trusted-encrypted.rst
> +++ b/Documentation/security/keys/trusted-encrypted.rst
> @@ -39,10 +39,9 @@ With the IBM TSS 2 stack::
>
> Or with the Intel TSS 2 stack::
>
> - #> tpm2_createprimary --hierarchy o -G rsa2048 -o key.ctxt
> + #> tpm2_createprimary --hierarchy o -G rsa2048 -c key.ctxt
> [...]
> - handle: 0x800000FF
> - #> tpm2_evictcontrol -c key.ctxt -p 0x81000001
> + #> tpm2_evictcontrol -c key.ctxt 0x81000001
> persistentHandle: 0x81000001
>
> Usage::
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] docs: trusted-encrypted.rst: update parameters for command examples
2020-08-19 21:02 ` Jarkko Sakkinen
@ 2020-08-19 21:04 ` Jarkko Sakkinen
2020-08-21 13:50 ` Coly Li
2020-08-19 23:03 ` Stefan Berger
1 sibling, 1 reply; 6+ messages in thread
From: Jarkko Sakkinen @ 2020-08-19 21:04 UTC (permalink / raw)
To: Coly Li
Cc: keyrings, linux-kernel, Dan Williams, James Bottomley, Mimi Zohar,
Stefan Berger
On Thu, Aug 20, 2020 at 12:02:38AM +0300, Jarkko Sakkinen wrote:
> On Wed, Aug 19, 2020 at 01:00:02AM +0800, Coly Li wrote:
> > The parameters in command examples for tpm2_createprimary and
> > tpm2_evictcontrol are outdated, people (like me) are not able to create
> > trusted key by these command examples.
> >
> > This patch updates the parameters of command example tpm2_createprimary
> > and tpm2_evictcontrol in trusted-encrypted.rst. With Linux kernel v5.8
> > and tpm2-tools-4.1, people can create a trusted key by following the
> > examples in this document.
> >
> > Signed-off-by: Coly Li <colyli@suse.de>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: James Bottomley <jejb@linux.ibm.com>
> > Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > Cc: Mimi Zohar <zohar@linux.ibm.com>
> > Cc: Stefan Berger <stefanb@linux.ibm.com>
>
> OK, now it is clear. Thank you.
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
There is one problem though.
You have missed to add linux-doc and linux-integrity maintainers and
also their maintainers from the CC list. You need to resend this patch
with that information. Use get_maintainers.pl or look from the file
called MAINTAINERS.
/Jarkko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] docs: trusted-encrypted.rst: update parameters for command examples
2020-08-19 21:04 ` Jarkko Sakkinen
@ 2020-08-21 13:50 ` Coly Li
2020-08-21 17:43 ` Jarkko Sakkinen
0 siblings, 1 reply; 6+ messages in thread
From: Coly Li @ 2020-08-21 13:50 UTC (permalink / raw)
To: Jarkko Sakkinen
Cc: keyrings, linux-kernel, Dan Williams, James Bottomley, Mimi Zohar,
Stefan Berger
On 2020/8/20 05:04, Jarkko Sakkinen wrote:
> On Thu, Aug 20, 2020 at 12:02:38AM +0300, Jarkko Sakkinen wrote:
>> On Wed, Aug 19, 2020 at 01:00:02AM +0800, Coly Li wrote:
>>> The parameters in command examples for tpm2_createprimary and
>>> tpm2_evictcontrol are outdated, people (like me) are not able to create
>>> trusted key by these command examples.
>>>
>>> This patch updates the parameters of command example tpm2_createprimary
>>> and tpm2_evictcontrol in trusted-encrypted.rst. With Linux kernel v5.8
>>> and tpm2-tools-4.1, people can create a trusted key by following the
>>> examples in this document.
>>>
>>> Signed-off-by: Coly Li <colyli@suse.de>
>>> Cc: Dan Williams <dan.j.williams@intel.com>
>>> Cc: James Bottomley <jejb@linux.ibm.com>
>>> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>>> Cc: Mimi Zohar <zohar@linux.ibm.com>
>>> Cc: Stefan Berger <stefanb@linux.ibm.com>
>>
>> OK, now it is clear. Thank you.
>>
>> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> There is one problem though.
>
> You have missed to add linux-doc and linux-integrity maintainers and
> also their maintainers from the CC list. You need to resend this patch
> with that information. Use get_maintainers.pl or look from the file
> called MAINTAINERS.
Copied. Some of the maintainers are in Cc list already, I add rested in
v4 patch, and Cc linux-doc and linux-integrity mailing lists.
Thanks.
Coly Li
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] docs: trusted-encrypted.rst: update parameters for command examples
2020-08-21 13:50 ` Coly Li
@ 2020-08-21 17:43 ` Jarkko Sakkinen
0 siblings, 0 replies; 6+ messages in thread
From: Jarkko Sakkinen @ 2020-08-21 17:43 UTC (permalink / raw)
To: Coly Li
Cc: keyrings, linux-kernel, Dan Williams, James Bottomley, Mimi Zohar,
Stefan Berger
On Fri, Aug 21, 2020 at 09:50:16PM +0800, Coly Li wrote:
> On 2020/8/20 05:04, Jarkko Sakkinen wrote:
> > On Thu, Aug 20, 2020 at 12:02:38AM +0300, Jarkko Sakkinen wrote:
> >> On Wed, Aug 19, 2020 at 01:00:02AM +0800, Coly Li wrote:
> >>> The parameters in command examples for tpm2_createprimary and
> >>> tpm2_evictcontrol are outdated, people (like me) are not able to create
> >>> trusted key by these command examples.
> >>>
> >>> This patch updates the parameters of command example tpm2_createprimary
> >>> and tpm2_evictcontrol in trusted-encrypted.rst. With Linux kernel v5.8
> >>> and tpm2-tools-4.1, people can create a trusted key by following the
> >>> examples in this document.
> >>>
> >>> Signed-off-by: Coly Li <colyli@suse.de>
> >>> Cc: Dan Williams <dan.j.williams@intel.com>
> >>> Cc: James Bottomley <jejb@linux.ibm.com>
> >>> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> >>> Cc: Mimi Zohar <zohar@linux.ibm.com>
> >>> Cc: Stefan Berger <stefanb@linux.ibm.com>
> >>
> >> OK, now it is clear. Thank you.
> >>
> >> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> >
> > There is one problem though.
> >
> > You have missed to add linux-doc and linux-integrity maintainers and
> > also their maintainers from the CC list. You need to resend this patch
> > with that information. Use get_maintainers.pl or look from the file
> > called MAINTAINERS.
>
> Copied. Some of the maintainers are in Cc list already, I add rested in
> v4 patch, and Cc linux-doc and linux-integrity mailing lists.
Please do.
> Thanks.
>
> Coly Li
BR,
/Jarkko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] docs: trusted-encrypted.rst: update parameters for command examples
2020-08-19 21:02 ` Jarkko Sakkinen
2020-08-19 21:04 ` Jarkko Sakkinen
@ 2020-08-19 23:03 ` Stefan Berger
1 sibling, 0 replies; 6+ messages in thread
From: Stefan Berger @ 2020-08-19 23:03 UTC (permalink / raw)
To: Jarkko Sakkinen, Coly Li
Cc: keyrings, linux-kernel, Dan Williams, James Bottomley, Mimi Zohar
On 8/19/20 5:02 PM, Jarkko Sakkinen wrote:
> On Wed, Aug 19, 2020 at 01:00:02AM +0800, Coly Li wrote:
>> The parameters in command examples for tpm2_createprimary and
>> tpm2_evictcontrol are outdated, people (like me) are not able to create
>> trusted key by these command examples.
>>
>> This patch updates the parameters of command example tpm2_createprimary
>> and tpm2_evictcontrol in trusted-encrypted.rst. With Linux kernel v5.8
>> and tpm2-tools-4.1, people can create a trusted key by following the
>> examples in this document.
>>
>> Signed-off-by: Coly Li <colyli@suse.de>
>> Cc: Dan Williams <dan.j.williams@intel.com>
>> Cc: James Bottomley <jejb@linux.ibm.com>
>> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>> Cc: Mimi Zohar <zohar@linux.ibm.com>
>> Cc: Stefan Berger <stefanb@linux.ibm.com>
> OK, now it is clear. Thank you.
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
>
> /Jarkko
>
>> ---
>> Changelog:
>> v3: update commit log with review comments from Jarkko Sakkinen.
>> v2: remove the change of trusted key related operation.
>> v1: initial version.
>>
>> Documentation/security/keys/trusted-encrypted.rst | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/security/keys/trusted-encrypted.rst b/Documentation/security/keys/trusted-encrypted.rst
>> index 9483a7425ad5..1da879a68640 100644
>> --- a/Documentation/security/keys/trusted-encrypted.rst
>> +++ b/Documentation/security/keys/trusted-encrypted.rst
>> @@ -39,10 +39,9 @@ With the IBM TSS 2 stack::
>>
>> Or with the Intel TSS 2 stack::
>>
>> - #> tpm2_createprimary --hierarchy o -G rsa2048 -o key.ctxt
>> + #> tpm2_createprimary --hierarchy o -G rsa2048 -c key.ctxt
>> [...]
>> - handle: 0x800000FF
>> - #> tpm2_evictcontrol -c key.ctxt -p 0x81000001
>> + #> tpm2_evictcontrol -c key.ctxt 0x81000001
>> persistentHandle: 0x81000001
>>
>> Usage::
>> --
>> 2.26.2
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-21 17:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-18 17:00 [PATCH v3] docs: trusted-encrypted.rst: update parameters for command examples Coly Li
2020-08-19 21:02 ` Jarkko Sakkinen
2020-08-19 21:04 ` Jarkko Sakkinen
2020-08-21 13:50 ` Coly Li
2020-08-21 17:43 ` Jarkko Sakkinen
2020-08-19 23:03 ` Stefan Berger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox