Re: [PATCH v3] docs: trusted-encrypted.rst: update parameters for command examples

Jarkko Sakkinen
2020-08-19T21:05:06Z

On Thu, Aug 20, 2020 at 12:02:38AM +0300, Jarkko Sakkinen wrote:
> On Wed, Aug 19, 2020 at 01:00:02AM +0800, Coly Li wrote:
> > The parameters in command examples for tpm2_createprimary and
> > tpm2_evictcontrol are outdated, people (like me) are not able to create
> > trusted key by these command examples.
> >
> > This patch updates the parameters of command example tpm2_createprimary
> > and tpm2_evictcontrol in trusted-encrypted.rst. With Linux kernel v5.8
> > and tpm2-tools-4.1, people can create a trusted key by following the
> > examples in this document.
> >
> > Signed-off-by: Coly Li <colyli@suse.de>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: James Bottomley <jejb@linux.ibm.com>
> > Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > Cc: Mimi Zohar <zohar@linux.ibm.com>
> > Cc: Stefan Berger <stefanb@linux.ibm.com>
>
> OK, now it is clear. Thank you.
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

There is one problem though.

You have missed to add linux-doc and linux-integrity maintainers and
also their maintainers from the CC list. You need to resend this patch
with that information. Use get_maintainers.pl or look from the file
called MAINTAINERS.

/Jarkko