From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CEEEC433E3 for ; Sat, 22 Aug 2020 09:22:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DA0E208E4 for ; Sat, 22 Aug 2020 09:22:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726676AbgHVJWT (ORCPT ); Sat, 22 Aug 2020 05:22:19 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:52966 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725864AbgHVJWR (ORCPT ); Sat, 22 Aug 2020 05:22:17 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 8958F80516; Sat, 22 Aug 2020 11:22:12 +0200 (CEST) Date: Sat, 22 Aug 2020 11:22:10 +0200 From: Sam Ravnborg To: Enric Balletbo i Serra Cc: linux-kernel@vger.kernel.org, Jernej Skrabec , drinkcat@chromium.org, Jonas Karlman , David Airlie , Neil Armstrong , dri-devel@lists.freedesktop.org, Andrzej Hajda , Laurent Pinchart , hsinyi@chromium.org, matthias.bgg@gmail.com, Collabora Kernel ML Subject: Re: [PATCH 1/3] drm/bridge: ps8640: Return an error for incorrect attach flags Message-ID: <20200822092210.GA430436@ravnborg.org> References: <20200615205320.790334-1-enric.balletbo@collabora.com> <20200615205320.790334-2-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200615205320.790334-2-enric.balletbo@collabora.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=aP3eV41m c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=QX4gbG5DAAAA:8 a=7gkXJVJtAAAA:8 a=e5mUnYsNAAAA:8 a=64DzJaDqLos1TpBtdjwA:9 a=CjuIK1q_8ugA:10 a=AbAUZ8qAyYyZVLSsDulk:22 a=E9Po1WZjFZOl8hwRPBS3:22 a=Vxmtnl_E_bksehYqCbjh:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Enric. On Mon, Jun 15, 2020 at 10:53:18PM +0200, Enric Balletbo i Serra wrote: > Bridge drivers that implement the new model only shall return an error > from their attach() handler when the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag > is not set. So make sure we return an error because only the new > drm_bridge model is supported. > > Signed-off-by: Enric Balletbo i Serra Reviewed-by: Sam Ravnborg I will await the updated series before applying. > --- > > drivers/gpu/drm/bridge/parade-ps8640.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c > index 13755d278db6d..ce3e8b2da8c9b 100644 > --- a/drivers/gpu/drm/bridge/parade-ps8640.c > +++ b/drivers/gpu/drm/bridge/parade-ps8640.c > @@ -200,6 +200,10 @@ static int ps8640_bridge_attach(struct drm_bridge *bridge, > .channel = 0, > .node = NULL, > }; > + > + if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) > + return -EINVAL; > + > /* port@0 is ps8640 dsi input port */ > in_ep = of_graph_get_endpoint_by_regs(dev->of_node, 0, -1); > if (!in_ep) > -- > 2.27.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel