From: Greg KH <gregkh@linuxfoundation.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Prateek Sood <prsood@codeaurora.org>,
mcgrof@kernel.org, rafael@kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v3] firmware_loader: fix memory leak for paged buffer
Date: Mon, 24 Aug 2020 10:21:47 +0200 [thread overview]
Message-ID: <20200824082147.GB336539@kroah.com> (raw)
In-Reply-To: <s5hy2m48nh5.wl-tiwai@suse.de>
On Mon, Aug 24, 2020 at 10:19:50AM +0200, Takashi Iwai wrote:
> On Thu, 20 Aug 2020 22:57:50 +0200,
> Prateek Sood wrote:
> >
> > vfree() is being called on paged buffer allocated
> > using alloc_page() and mapped using vmap().
> >
> > Freeing of pages in vfree() relies on nr_pages of
> > struct vm_struct. vmap() does not update nr_pages.
> > It can lead to memory leaks.
> >
> > Fixes: ddaf29fd9bb6 ("firmware: Free temporary page table after vmapping")
> > Signed-off-by: Prateek Sood <prsood@codeaurora.org>
> > Reviewed-by: Takashi Iwai <tiwai@suse.de>
> > Cc: stable@vger.kernel.org
>
> Greg, could you review and merge this one please?
It's in my to-review queue, thanks.
greg k-h
prev parent reply other threads:[~2020-08-24 8:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 19:00 [PATCH] firmware_loader: fix memory leak for paged buffer Prateek Sood
2020-08-13 12:58 ` Takashi Iwai
2020-08-13 19:51 ` Prateek Sood
2020-08-13 20:00 ` [PATCH v2] " Prateek Sood
2020-08-17 12:12 ` Takashi Iwai
2020-08-20 20:57 ` [PATCH v3] " Prateek Sood
2020-08-24 8:19 ` Takashi Iwai
2020-08-24 8:21 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824082147.GB336539@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=prsood@codeaurora.org \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox