From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD6BEC433DF for ; Mon, 24 Aug 2020 08:50:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DACD2075B for ; Mon, 24 Aug 2020 08:50:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598259055; bh=UCnJzkF6jvo0O/ktC5flsal+jXhEzxyjOp0Dxit5d6I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=TJWz+5vFi5UzJhMKOV1V+19ACwMoKgZBC72jwuCii0Q5VZek+Zjy3XKHVS5EGb8vF laBc6LhiPWopwrk8GAjgcs6Tdwe9/H00sXkCN778+yK85ATq5RYAvgwHb1PCkxbbYc SlcG3clU5lLXKRiMhqSDOgzcnC7aNdh9qZXaPOWs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729874AbgHXIuy (ORCPT ); Mon, 24 Aug 2020 04:50:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:54814 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729621AbgHXIup (ORCPT ); Mon, 24 Aug 2020 04:50:45 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1ABAD2075B; Mon, 24 Aug 2020 08:50:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598259044; bh=UCnJzkF6jvo0O/ktC5flsal+jXhEzxyjOp0Dxit5d6I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D4kq8cJdeGnK3HXs1K8VbYXlCE64SP4KEH6IdSIa4/aUpLiXzciLftUkiHwVOw4/z IBKcgWtIZbgVOiWO0OdW5jj5oKgd2dNh7tXmWNVFMbBnDpyi4c04HO4ACOLwZbMLVq ZMOl+AhiohrNuXA+e7OtL9+F7gI9iH8wS/rWk3nw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Greg Kroah-Hartman , "tomi.valkeinen@ti.com, aford@beaconembedded.com, Adam Ford" , tomi.valkeinen@ti.com, Adam Ford Subject: [PATCH 4.4 33/33] omapfb: dss: Fix max fclk divider for omap36xx Date: Mon, 24 Aug 2020 10:31:29 +0200 Message-Id: <20200824082348.191071695@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200824082346.498653578@linuxfoundation.org> References: <20200824082346.498653578@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Adam Ford There appears to be a timing issue where using a divider of 32 breaks the DSS for OMAP36xx despite the TRM stating 32 is a valid number. Through experimentation, it appears that 31 works. This same fix was issued for kernels 4.5+. However, between kernels 4.4 and 4.5, the directory structure was changed when the dss directory was moved inside the omapfb directory. That broke the patch on kernels older than 4.5, because it didn't permit the patch to apply cleanly for 4.4 and older. A similar patch was applied to the 3.16 kernel already, but not to 4.4. Commit 4b911101a5cd ("drm/omap: fix max fclk divider for omap36xx") is on the 3.16 stable branch with notes from Ben about the path change. Since this was applied for 3.16 already, this patch is for kernels 3.17 through 4.4 only. Fixes: f7018c213502 ("video: move fbdev to drivers/video/fbdev") Cc: #3.17 - 4.4 CC: Signed-off-by: Adam Ford Signed-off-by: Greg Kroah-Hartman --- drivers/video/fbdev/omap2/dss/dss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/video/fbdev/omap2/dss/dss.c +++ b/drivers/video/fbdev/omap2/dss/dss.c @@ -843,7 +843,7 @@ static const struct dss_features omap34x }; static const struct dss_features omap3630_dss_feats = { - .fck_div_max = 32, + .fck_div_max = 31, .dss_fck_multiplier = 1, .parent_clk_name = "dpll4_ck", .dpi_select_source = &dss_dpi_select_source_omap2_omap3,