Re: [PATCH 4.19 22/71] scsi: target: tcmu: Fix crash in tcmu_flush_dcache_range on ARM

Pavel Machek
2020-08-25T19:46:25Z

[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]

Hi!

> From: Bodo Stroesser <bstroesser@ts.fujitsu.com>
>
> [ Upstream commit 3145550a7f8b08356c8ff29feaa6c56aca12901d ]
>
> This patch fixes the following crash (see
> https://bugzilla.kernel.org/show_bug.cgi?id=208045)
>
> Process iscsi_trx (pid: 7496, stack limit = 0x0000000010dd111a)
> CPU: 0 PID: 7496 Comm: iscsi_trx Not tainted 4.19.118-0419118-generic
> #202004230533
> Hardware name: Greatwall QingTian DF720/F601, BIOS 601FBE20 Sep 26 2019
> pstate: 80400005 (Nzcv daif +PAN -UAO)
...
> The solution is based on patch:
>
> "scsi: target: tcmu: Optimize use of flush_dcache_page"
>
> which restricts the use of tcmu_flush_dcache_range() to addresses from
> vmalloc'ed areas only.

Yeah, but the patch mentioned is not queued for 4.19, so we should not
be simply applying this to 4.19. Does it need to be cherry-picked,
too?

commit 3c58f737231e2c8cbf543a09d84d8c8e80e05e43
Author: Bodo Stroesser <bstroesser@ts.fujitsu.com>

scsi: target: tcmu: Optimize use of flush_dcache_page

(scatter|gather)_data_area() need to flush dcache after writing data to or

Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]