From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6A2EC433E3 for ; Mon, 24 Aug 2020 08:46:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BCAF422B3F for ; Mon, 24 Aug 2020 08:46:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598258816; bh=U1u6ehBMN1TSDawPESs3Nv2ss5ugOulhMj+FxlnMsqY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=FXFFfBNouc+OLZO9vj4nhDuGqTN6/JmVatDzpaqpoVInfI4s6OeblMRStDglx7i5T Ci2Q6zGBzDt9CGGYRdp8z8hdGC9bn3jvaRekLfGvP8EDVUqBmeSHsM71IqpldRq6zP EKCQhv2gFvNUiUtZCNwT2/b4+BsTYqCt7fShubg0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729398AbgHXIqz (ORCPT ); Mon, 24 Aug 2020 04:46:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:45750 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729390AbgHXIqu (ORCPT ); Mon, 24 Aug 2020 04:46:50 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 63115206F0; Mon, 24 Aug 2020 08:46:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598258810; bh=U1u6ehBMN1TSDawPESs3Nv2ss5ugOulhMj+FxlnMsqY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tqWQKDTlY5SK8QmY4y2g4GmsC9E8c48L0r6MtalNFAjWCk7WFPp6vzU6IVvmhr+Vn 5Wj1kuZMCI0J+WNw2gWyAUDa/El8NsSVrJDQrdsdjEDfX7rl+mYhddeskhGLqbFZyd E0gI0QsX6KNaQXgATD3cYTxvyf5yQRY67AXHv3kg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+b57f46d8d6ea51960b8c@syzkaller.appspotmail.com, Xiubo Li , Jeff Layton , Ilya Dryomov , Sasha Levin Subject: [PATCH 5.4 053/107] ceph: fix use-after-free for fsc->mdsc Date: Mon, 24 Aug 2020 10:30:19 +0200 Message-Id: <20200824082407.764178753@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200824082405.020301642@linuxfoundation.org> References: <20200824082405.020301642@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiubo Li [ Upstream commit a7caa88f8b72c136f9a401f498471b8a8e35370d ] If the ceph_mdsc_init() fails, it will free the mdsc already. Reported-by: syzbot+b57f46d8d6ea51960b8c@syzkaller.appspotmail.com Signed-off-by: Xiubo Li Reviewed-by: Jeff Layton Signed-off-by: Ilya Dryomov Signed-off-by: Sasha Levin --- fs/ceph/mds_client.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c index 701bc3f4d4ba1..b0077f5a31688 100644 --- a/fs/ceph/mds_client.c +++ b/fs/ceph/mds_client.c @@ -4143,7 +4143,6 @@ int ceph_mdsc_init(struct ceph_fs_client *fsc) return -ENOMEM; } - fsc->mdsc = mdsc; init_completion(&mdsc->safe_umount_waiters); init_waitqueue_head(&mdsc->session_close_wq); INIT_LIST_HEAD(&mdsc->waiting_for_map); @@ -4195,6 +4194,8 @@ int ceph_mdsc_init(struct ceph_fs_client *fsc) strscpy(mdsc->nodename, utsname()->nodename, sizeof(mdsc->nodename)); + + fsc->mdsc = mdsc; return 0; } -- 2.25.1