From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B40DC433E1 for ; Mon, 24 Aug 2020 08:34:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F7FE206F0 for ; Mon, 24 Aug 2020 08:34:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598258053; bh=YDZpUwQqgrjca26/YxEEBcLteZJTIimiUUrp879M/e0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=QFNM1LfLNBo2o81IG1T0OPi2SnOM3ViHRmR1okw61i3BrzxSp/yMLigSuyTrz0ZeA a7ju7Forx7ggjR5BZVl+PsGoGG2dCoVCxEhidXpsyJ0ITvddUDu5H5frM0VNn13CMd KxRbD9fvqDv5sbRP27h4Y2CD+R5ME1M0UBgFoklI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727864AbgHXIeL (ORCPT ); Mon, 24 Aug 2020 04:34:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:42012 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727824AbgHXId7 (ORCPT ); Mon, 24 Aug 2020 04:33:59 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D82AA206F0; Mon, 24 Aug 2020 08:33:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598258039; bh=YDZpUwQqgrjca26/YxEEBcLteZJTIimiUUrp879M/e0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dVOP3WOyn4HrhXYHaQrrvHfgy2FcH+HZUXJb4I9I95sMSQIheOYMHRUfFnF6W1bSo LXwK/ohTg5S8sjbJwqK5eUcaBw20nk56VSggYW42gVAXiKpHPhvx8KGdQzgrRDrPoI CE2uhii/W0gGuTcZ3Zm9iG2kIykbH8DGLG2x5FWQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Huacai Chen , Jiaxun Yang , Alexandre Belloni , Sasha Levin Subject: [PATCH 5.8 050/148] rtc: goldfish: Enable interrupt in set_alarm() when necessary Date: Mon, 24 Aug 2020 10:29:08 +0200 Message-Id: <20200824082416.469326102@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200824082413.900489417@linuxfoundation.org> References: <20200824082413.900489417@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Huacai Chen [ Upstream commit 22f8d5a1bf230cf8567a4121fc3789babb46336d ] When use goldfish rtc, the "hwclock" command fails with "select() to /dev/rtc to wait for clock tick timed out". This is because "hwclock" need the set_alarm() hook to enable interrupt when alrm->enabled is true. This operation is missing in goldfish rtc (but other rtc drivers, such as cmos rtc, enable interrupt here), so add it. Signed-off-by: Huacai Chen Signed-off-by: Jiaxun Yang Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/1592654683-31314-1-git-send-email-chenhc@lemote.com Signed-off-by: Sasha Levin --- drivers/rtc/rtc-goldfish.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rtc/rtc-goldfish.c b/drivers/rtc/rtc-goldfish.c index 27797157fcb3f..6349d2cd36805 100644 --- a/drivers/rtc/rtc-goldfish.c +++ b/drivers/rtc/rtc-goldfish.c @@ -73,6 +73,7 @@ static int goldfish_rtc_set_alarm(struct device *dev, rtc_alarm64 = rtc_tm_to_time64(&alrm->time) * NSEC_PER_SEC; writel((rtc_alarm64 >> 32), base + TIMER_ALARM_HIGH); writel(rtc_alarm64, base + TIMER_ALARM_LOW); + writel(1, base + TIMER_IRQ_ENABLED); } else { /* * if this function was called with enabled=0 -- 2.25.1