From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C840AC433DF for ; Mon, 24 Aug 2020 08:58:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A78842072D for ; Mon, 24 Aug 2020 08:58:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598259524; bh=MlJ44rehLSPaJUGChKnzLkZMd/wcW1D2ek38r9QI/p8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=MbOHals1c1OoRXx31+HZrMvUUMBIVGyPrCd1aPyeW78fsTmIgygWqgEc8dxz/m2gX nEJSNTXBYo/Ba2qIVegLpRApApBGX6nlUR4UHatCCyG5FpRuWCXuByfHrT6b49wURX AlP6CRMALHUqWTMZBDCN1zNnRzdpTHfZ5+OWavrk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729116AbgHXI6m (ORCPT ); Mon, 24 Aug 2020 04:58:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:46642 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730771AbgHXI6V (ORCPT ); Mon, 24 Aug 2020 04:58:21 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 29221204FD; Mon, 24 Aug 2020 08:58:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598259500; bh=MlJ44rehLSPaJUGChKnzLkZMd/wcW1D2ek38r9QI/p8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iQoFk1hEPIycH6uvZnb6VQY5N8y5Q4wF2KotBVBfTw4Ld3c4RRAawn3DrFWbwqdYn e6RCVfW7DOX61v//zMbh+8Mvel8hvYb1AvKy3bM7s/pVnlxnbF1BjUAXBomGMNiDAz f4DQsO2cphJ9wmNYH6WwxaGmlsz/IvbnyqXcZVoM= Date: Mon, 24 Aug 2020 10:57:16 +0200 From: Greg KH To: Qiwu Huang Cc: Sebastian Reichel , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Qiwu Huang Subject: Re: [PATCH v8 1/4] power: supply: core: add quick charge type property Message-ID: <20200824085715.GB402243@kroah.com> References: <20200814060909.GD1409566@kroah.com> <20200818060707.GB1742213@kroah.com> <20200824074357.GB4133866@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 24, 2020 at 04:42:06PM +0800, Qiwu Huang wrote: > On Mon, Aug 24, 2020 at 3:43 PM Greg KH wrote: > > > > On Mon, Aug 24, 2020 at 08:54:56AM +0800, Qiwu Huang wrote: > > > On Tue, Aug 18, 2020 at 2:07 PM Greg KH wrote: > > > > > > > > On Tue, Aug 18, 2020 at 09:56:28AM +0800, Qiwu Huang wrote: > > > > > On Fri, Aug 14, 2020 at 2:09 PM Greg KH wrote: > > > > > > > > > > > > On Fri, Aug 14, 2020 at 11:46:54AM +0800, Qiwu Huang wrote: > > > > > > > From: Qiwu Huang > > > > > > > > > > > > > > Reports the kind of quick charge type based on > > > > > > > different adapter power. > > > > > > > > > > > > > > Signed-off-by: Qiwu Huang > > > > > > > --- > > > > > > > Documentation/ABI/testing/sysfs-class-power | 21 +++++++++ > > > > > > > drivers/power/supply/power_supply_sysfs.c | 1 + > > > > > > > drivers/power/supply/qcom_smbb.c | 51 +++++++++++++++++++++ > > > > > > > include/linux/power_supply.h | 14 ++++++ > > > > > > > 4 files changed, 87 insertions(+) > > > > > > > > > > > > You should also submit your driver that uses these new attributes at the > > > > > > same time. What happened to that request? Otherwise no one really > > > > > > knows how these are being used, or if they even are used by anyone. > > > > > > > > > > > > > > > > I don't think I can submit the whole driver because our drivers are > > > > > divided into three parts, the first part is in ADSP, the second part > > > > > is in kernel and the third part is in Android Hal.This is the second > > > > > part. > > > > > > > > WHat is "ADSP"? > > > > > > ADSP: advanced digital signal processor > > > > Ok, then just send the kernel driver. > > > > > > Just submit your kernel driver code, that's all we care about here. > > > > Userspace code is not anything we can do anything with :) > > > > > > If we ported the full driver, we would break the existing driver > > > structure because we would introduce more Qualcomm code. I think > > > that's an unreasonable change. > > > > That doesn't make much sense. You have a working driver for these apis, > > just submit it for inclusion, it should never break any existing > > drivers, otherwise your code wouldn't work either. > > We're an Android device, we're working on a Qualcomm based code, and > from the current code tree, the current code tree is missing the QTI > Charger code I don't know what that means, sorry. Just submit your driver, and any needed dependencies as well. There's no other way to evaluate this api addition without that, right? thanks, greg k-h