From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BC12C433E1 for ; Mon, 24 Aug 2020 10:58:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55F3E2074D for ; Mon, 24 Aug 2020 10:58:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727053AbgHXK6m (ORCPT ); Mon, 24 Aug 2020 06:58:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:43168 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726187AbgHXK6T (ORCPT ); Mon, 24 Aug 2020 06:58:19 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1AC73AE17; Mon, 24 Aug 2020 10:58:48 +0000 (UTC) Date: Mon, 24 Aug 2020 12:58:16 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Andrew Morton , Wei Yang , Baoquan He , Pankaj Gupta , Mel Gorman Subject: Re: [PATCH v2 08/10] mm/page_alloc: drop stale pageblock comment in memmap_init_zone*() Message-ID: <20200824105815.GH6315@linux> References: <20200819175957.28465-1-david@redhat.com> <20200819175957.28465-9-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200819175957.28465-9-david@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 19, 2020 at 07:59:55PM +0200, David Hildenbrand wrote: > Commit ac5d2539b238 ("mm: meminit: reduce number of times pageblocks are > set during struct page init") moved the actual zone range check, leaving > only the alignment check for pageblocks. > > Let's drop the stale comment and make the pageblock check easier to read. > > Acked-by: Michal Hocko > Cc: Andrew Morton > Cc: Michal Hocko > Cc: Wei Yang > Cc: Baoquan He > Cc: Pankaj Gupta > Cc: Oscar Salvador > Cc: Mel Gorman > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE L3