From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
x86@kernel.org, Linus Torvalds <torvalds@linux-foundation.org>,
Tom Lendacky <thomas.lendacky@amd.com>, Pu Wen <puwen@hygon.cn>,
Stephen Hemminger <sthemmin@microsoft.com>,
Sasha Levin <alexander.levin@microsoft.com>,
Dirk Hohndel <dirkhh@vmware.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Asit Mallick <asit.k.mallick@intel.com>,
Gordon Tetlow <gordon@tetlows.org>,
David Kaplan <David.Kaplan@amd.com>,
Tony Luck <tony.luck@intel.com>,
Andy Lutomirski <luto@kernel.org>
Subject: TDX #VE in SYSCALL gap (was: [RFD] x86: Curing the exception and syscall trainwreck in hardware)
Date: Mon, 24 Aug 2020 21:39:59 -0700 [thread overview]
Message-ID: <20200825043959.GF15046@sjchrist-ice> (raw)
In-Reply-To: <3babf003-6854-e50a-34ca-c87ce4169c77@citrix.com>
+Andy
On Mon, Aug 24, 2020 at 02:52:01PM +0100, Andrew Cooper wrote:
> And to help with coordination, here is something prepared (slightly)
> earlier.
>
> https://docs.google.com/document/d/1hWejnyDkjRRAW-JEsRjA5c9CKLOPc6VKJQsuvODlQEI/edit?usp=sharing
>
> This identifies the problems from software's perspective, along with
> proposing behaviour which ought to resolve the issues.
>
> It is still a work-in-progress. The #VE section still needs updating in
> light of the publication of the recent TDX spec.
For #VE on memory accesses in the SYSCALL gap (or NMI entry), is this
something we (Linux) as the guest kernel actually want to handle gracefully
(where gracefully means not panicking)? For TDX, a #VE in the SYSCALL gap
would require one of two things:
a) The guest kernel to not accept/validate the GPA->HPA mapping for the
relevant pages, e.g. code or scratch data.
b) The host VMM to remap the GPA (making the GPA->HPA pending again).
(a) is only possible if there's a fatal buggy guest kernel (or perhaps vBIOS).
(b) requires either a buggy or malicious host VMM.
I ask because, if the answer is "no, panic at will", then we shouldn't need
to burn an IST for TDX #VE. Exceptions won't morph to #VE and hitting an
instruction based #VE in the SYSCALL gap would be a CPU bug or a kernel bug.
Ditto for a #VE in NMI entry before it gets to a thread stack.
Am I missing anything?
next prev parent reply other threads:[~2020-08-25 4:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 12:24 [RFD] x86: Curing the exception and syscall trainwreck in hardware Thomas Gleixner
2020-08-24 13:52 ` Andrew Cooper
2020-08-25 4:39 ` Sean Christopherson [this message]
2020-08-25 15:25 ` TDX #VE in SYSCALL gap (was: [RFD] x86: Curing the exception and syscall trainwreck in hardware) Dave Hansen
2020-08-25 16:49 ` Andy Lutomirski
2020-08-25 17:19 ` Sean Christopherson
2020-08-25 17:28 ` Andy Lutomirski
2020-08-25 17:35 ` Luck, Tony
2020-08-25 17:41 ` Andy Lutomirski
2020-08-25 17:59 ` Andrew Cooper
2020-08-25 18:38 ` Dave Hansen
2020-08-25 19:49 ` Thomas Gleixner
2020-08-26 19:16 ` Sean Christopherson
2020-08-30 15:37 ` Andy Lutomirski
2020-08-30 18:37 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825043959.GF15046@sjchrist-ice \
--to=sean.j.christopherson@intel.com \
--cc=David.Kaplan@amd.com \
--cc=TonyWWang-oc@zhaoxin.com \
--cc=alexander.levin@microsoft.com \
--cc=andrew.cooper3@citrix.com \
--cc=asit.k.mallick@intel.com \
--cc=dirkhh@vmware.com \
--cc=gordon@tetlows.org \
--cc=hpa@linux.intel.com \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=puwen@hygon.cn \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox